fix: use absolute instead of running index to count position

[zewa666]

sry this issue somehow sneaked in during testing. ofc the returned indexes should be the absolute ones from the total collection

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.0%. Comparing base (ad3ca06) to head (1dd9d26).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2544   +/-   ##
=======================================
  Coverage   100.0%   100.0%           
=======================================
  Files         196      196           
  Lines       24964    24965    +1     
  Branches     8814     8815    +1     
=======================================
+ Hits        24964    24965    +1     

Flag	Coverage Δ
angular	100.0% <ø> (ø)
universal	100.0% <100.0%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pkg-pr-new]

angular-slickgrid

npm i https://pkg.pr.new/angular-slickgrid@2544

aurelia-slickgrid

npm i https://pkg.pr.new/aurelia-slickgrid@2544

slickgrid-react

npm i https://pkg.pr.new/slickgrid-react@2544

slickgrid-vue

npm i https://pkg.pr.new/slickgrid-vue@2544

@slickgrid-universal/angular-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/angular-row-detail-plugin@2544

@slickgrid-universal/aurelia-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/aurelia-row-detail-plugin@2544

@slickgrid-universal/react-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/react-row-detail-plugin@2544

@slickgrid-universal/vue-row-detail-plugin

npm i https://pkg.pr.new/@slickgrid-universal/vue-row-detail-plugin@2544

@slickgrid-universal/binding

npm i https://pkg.pr.new/@slickgrid-universal/binding@2544

@slickgrid-universal/common

npm i https://pkg.pr.new/@slickgrid-universal/common@2544

@slickgrid-universal/composite-editor-component

npm i https://pkg.pr.new/@slickgrid-universal/composite-editor-component@2544

@slickgrid-universal/custom-footer-component

npm i https://pkg.pr.new/@slickgrid-universal/custom-footer-component@2544

@slickgrid-universal/custom-tooltip-plugin

npm i https://pkg.pr.new/@slickgrid-universal/custom-tooltip-plugin@2544

@slickgrid-universal/empty-warning-component

npm i https://pkg.pr.new/@slickgrid-universal/empty-warning-component@2544

@slickgrid-universal/event-pub-sub

npm i https://pkg.pr.new/@slickgrid-universal/event-pub-sub@2544

@slickgrid-universal/excel-export

npm i https://pkg.pr.new/@slickgrid-universal/excel-export@2544

@slickgrid-universal/graphql

npm i https://pkg.pr.new/@slickgrid-universal/graphql@2544

@slickgrid-universal/odata

npm i https://pkg.pr.new/@slickgrid-universal/odata@2544

@slickgrid-universal/pagination-component

npm i https://pkg.pr.new/@slickgrid-universal/pagination-component@2544

@slickgrid-universal/pdf-export

npm i https://pkg.pr.new/@slickgrid-universal/pdf-export@2544

@slickgrid-universal/row-detail-view-plugin

npm i https://pkg.pr.new/@slickgrid-universal/row-detail-view-plugin@2544

@slickgrid-universal/rxjs-observable

npm i https://pkg.pr.new/@slickgrid-universal/rxjs-observable@2544

@slickgrid-universal/sql

npm i https://pkg.pr.new/@slickgrid-universal/sql@2544

@slickgrid-universal/text-export

npm i https://pkg.pr.new/@slickgrid-universal/text-export@2544

@slickgrid-universal/utils

npm i https://pkg.pr.new/@slickgrid-universal/utils@2544

@slickgrid-universal/vanilla-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-bundle@2544

@slickgrid-universal/vanilla-force-bundle

npm i https://pkg.pr.new/@slickgrid-universal/vanilla-force-bundle@2544

commit: 1dd9d26

[ghiscoding]

is that another thing related to hidden column? because this function wasn't changed in a very long time

[zewa666]

oh its not so long ago, actually just a day 🤣 sry if it was unclear but I contributed the cell++ whereas it should have been the actual absolute index cell + 1. But wait a bit please I sadly found another new bug

[ghiscoding]

ah ok yeah I didn't realized it was you in previous PR, but you changed it to a continue yesterday, can we write it like this instead:

slickgrid-universal/packages/common/src/core/slickGrid.ts

Lines 2936 to 2939 in da8e9d6

	if (this.columns[i] && !this.columns[i].hidden) {
	rules.push(`.${this.uid} .l${i} { }`);
	rules.push(`.${this.uid} .r${i} { }`);
	}

it's less lines of code but it's also less problems test coverage (and maybe less readable too but it's not that bad)

[zewa666]

so one more issue that I found was that if the to be pasted columns exceed amount of availble columns, which gets triggered when pasting multiple rows as the same time, we ran into a undefined.hidden error.

[zewa666]

I think we're good with this one so far, haven't found any new issues as of today

[ghiscoding]

yeah but can you make the change as suggested in my previous comment, you're also missing coverage for that new file mod... oh and formatting problem too, I'm not sure why Prettier vscode plugin no longer detects formatting changes (I won't switch to oxc/ofmt until they cover all inline templating aka js-in-html)

[zewa666]

yep ofc, will take a look today

[ghiscoding]

@zewa666 Great thanks again, are you done with all your testing or does that last a few days? I could push another version in the weekend or wait longer

[zewa666]

I think I'm good for this week. deploying by the weekend is totally fine. I'm sure we'll find more but that is an ongoing task

[github-actions]

🎉 This pull request is included in version 10.5.2 📦
🔗 The release notes are available at: GitHub Release 🚀