chore(lint): Enable eslint curly rule and auto-fix all violations#115697
Draft
ryan953 wants to merge 1 commit into
Draft
chore(lint): Enable eslint curly rule and auto-fix all violations#115697ryan953 wants to merge 1 commit into
ryan953 wants to merge 1 commit into
Conversation
Require curly braces around all control flow statements (if, else, for, while, do). The rule is added after eslint-config-prettier so it overrides prettier's disabling of the rule. All 124 files with violations have been auto-fixed and reformatted.
github-actions
Bot
added
the
Scope: Frontend
ryan953
changed the title
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.53% |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curlyrule at error level, requiring curly braces around all control flow statements (if,else,for,while,do)plugin/prettierconfig block so it overrideseslint-config-prettier's disabling of the rule (it's a "special rule" that's safe to use alongside formatters)oxfmtTest plan
curlyviolations viaeslintacrossstatic/app/,static/gsApp/,static/gsAdmin/,tests/js/, andstatic/eslint/