fix(testing): Correct organization context for replay.id link test#115696
Open
sentry[bot] wants to merge 1 commit into
Open
fix(testing): Correct organization context for replay.id link test#115696sentry[bot] wants to merge 1 commit into
sentry[bot] wants to merge 1 commit into
Conversation
Contributor
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.53% |
ryan953
approved these changes
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the
TestingLibraryElementError: Unable to find role="link"infieldRenderers.spec.tsx.The
renders replay.id as a link when replay existstest was failing because theuseReplayCounthook, which is used byViewReplayLink, relies onuseOrganization()to determine the organization slug for its API calls to/replay-count/.When
render()was called without explicitly passing theorganizationfixture, theOrganizationContextwithin the test environment was not correctly set. This causeduseReplayCountto construct an API URL with a default/incorrect organization slug, which did not match the URL set up byMockApiClient.addMockResponse.As a result, the mock API response was never triggered, the replay existence check failed, and
ViewReplayLinkrendered(missing)instead of the expected link, leading to thefindByRole('link')assertion timing out.The fix involves passing the
organizationfixture as an option to therender()call, ensuring thatuseOrganization()resolves the correct organization slug and thereplay-countAPI call correctly hits the mock.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
Fixes JEST-2332