ref(flags): Remove organizations:on-demand-metrics-extraction-experimental#115683
ref(flags): Remove organizations:on-demand-metrics-extraction-experimental#115683wedamija wants to merge 1 commit into
Conversation
github-actions
Bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
📊 Type Coverage Diff✅ No new type safety issues introduced. Coverage: 93.53% |
| <Switch checked={onDemand.forceOnDemand} size="sm" onChange={toggle} /> | ||
| </FlexContainer> | ||
| ); | ||
| return null; |
There was a problem hiding this comment.
looks like we could just remove this component since this is a noop?
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5f21e12. Configure here.
| on_demand_metrics = features.has("organizations:on-demand-metrics-extraction", org) | ||
| dashboard_on_demand_metrics = features.has( | ||
| "organizations:on-demand-metrics-extraction-experimental", org | ||
| ) |
There was a problem hiding this comment.
Dashboard config invalidation now triggers much more broadly
Medium Severity
schedule_update_project_configs previously required both on-demand-metrics-extraction AND on-demand-metrics-extraction-experimental to proceed. Since the experimental flag was never rolled out, this code path never executed in production. Now, by removing the experimental gate entirely, schedule_invalidate_project_config will fire for every org with the base on-demand-metrics-extraction flag on every dashboard create/update. The experimental flag likely guarded dashboard-specific on-demand behavior — the on-demand-metrics-extraction-widgets flag (already used elsewhere in this file for widget-related gating) seems like the appropriate replacement rather than removing the second check entirely.
Reviewed by Cursor Bugbot for commit 5f21e12. Configure here.
…ental Registered Jun 2023, dev-only, never rolled out to customers. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
wedamija
force-pushed
the
flag-cleanup/organizations-on-demand-metrics-extraction-experimental
branch
from
5f21e12 to
4b66c40
Compare
3 participants
Dev-only flag registered Jun 2023, never rolled out to customers. Remove the flag registration and the unreleased gated code paths.