ref(sentry-core): Refactor logs batching into generic Batcher#1018
Draft
szokeasaurusrex wants to merge 2 commits intomasterfrom
Draft
ref(sentry-core): Refactor logs batching into generic Batcher#1018szokeasaurusrex wants to merge 2 commits intomasterfrom
szokeasaurusrex wants to merge 2 commits intomasterfrom
Conversation
## Summary - Move logs batching implementation from `sentry-core/src/logs.rs` to `sentry-core/src/batcher.rs` so Git tracks it as a rename. - Generalize the batcher to `Batcher<T>` with an injected envelope-item conversion function. - Keep logs integration in `Client` by instantiating `Batcher<Log>`. - Update module wiring in `sentry-core/src/lib.rs` from `logs` to `batcher`. ## Why this approach - Preserve reviewability by starting from a file move and then applying minimal, local generic changes. - Keep issue #1007 scoped to logs behavior only, without metrics API changes. ## Behavior parity - Preserve flush-at-threshold behavior (100 items). - Preserve periodic flush interval (5s). - Preserve flush-on-drop and client-shutdown behavior. - Keep logs batching tests in place and passing. ## Validation - Ran `cargo fmt --all`. - Ran `cargo clippy -p sentry-core --features "client,logs" -- -Dwarnings`. - Ran `cargo test -p sentry-core --features "client,logs,test" --lib`. Closes #1007 Closes [RUST-158](https://linear.app/getsentry/issue/RUST-158/refactor-logs-batching-into-a-reusable-generic-batchert) Co-authored-by: Joris Bayer <joris.bayer@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sentry-core/src/logs.rstosentry-core/src/batcher.rsso Git tracks it as a rename.Batcher<T>with an injected envelope-item conversion function.Clientby instantiatingBatcher<Log>.sentry-core/src/lib.rsfromlogstobatcher.Why this approach
Behavior parity
Validation
cargo fmt --all.cargo clippy -p sentry-core --features "client,logs" -- -Dwarnings.cargo test -p sentry-core --features "client,logs,test" --lib.Closes #1007
Closes RUST-158
Co-authored-by: Joris Bayer joris.bayer@sentry.io