feat: Implement strict trace continuation (org_id validation)#1017
Draft
feat: Implement strict trace continuation (org_id validation)#1017
Conversation
- Parse org_id from DSN host (e.g., o1234.ingest.sentry.io → "1234") - Add `org_id` and `strict_trace_continuation` options to ClientOptions - Propagate org_id in Dynamic Sampling Context (DSC) - Add baggage header parsing for sentry-org_id - Validate org_id in continue_from_headers and OTel propagator Resolves #1016 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement the
strict_trace_continuationoption as specified in the SDK spec.This prevents unintended trace mixing across different Sentry organizations by validating the
org_idin incoming baggage headers.Changes:
org_idfrom DSN host (e.g.,o1234.ingest.sentry.io→"1234")org_idandstrict_trace_continuationoptions toClientOptionsorg_idin Dynamic Sampling Context (DSC)sentry-org_idcontinue_from_headersand OTel propagatororg_id()getter onDynamicSamplingContextIssues