Skip to content

feat(rails): support for solid queue#2942

Open
solnic wants to merge 2 commits into
2933-active-job-tracing-specsfrom
2587-support-solid-queue
Open

feat(rails): support for solid queue#2942
solnic wants to merge 2 commits into
2933-active-job-tracing-specsfrom
2587-support-solid-queue

Conversation

@solnic

@solnic solnic commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator

This adds support for SolideQueue by simply adding its spec suite that makes sure our common ActiveJob integration works with SolidQueue, including distributed tracing.

We may follow up with SQ-specific features added in separate PR(s).

⚠️ this builds on top of #2947 which should be reviewed/merged first.


Closes #2587

@solnic solnic linked an issue Apr 28, 2026 that may be closed by this pull request
@solnic solnic force-pushed the 2587-support-solid-queue branch from ba6dae4 to 0531f06 Compare April 30, 2026 13:23
@solnic solnic force-pushed the 2587-support-solid-queue branch from 396f231 to 22e181a Compare May 7, 2026 13:58
@solnic solnic changed the base branch from master to 2933-active-job-tracing-specs May 7, 2026 13:58
@solnic solnic force-pushed the 2933-active-job-tracing-specs branch 2 times, most recently from cafb0e5 to d61680a Compare May 12, 2026 08:14
@solnic solnic force-pushed the 2587-support-solid-queue branch from 22e181a to ad38485 Compare May 12, 2026 08:14
@solnic solnic force-pushed the 2933-active-job-tracing-specs branch 9 times, most recently from 826f69d to 1c0f001 Compare May 22, 2026 14:42
@solnic solnic force-pushed the 2587-support-solid-queue branch 2 times, most recently from 6322da1 to edaee65 Compare May 25, 2026 10:06
@solnic solnic force-pushed the 2587-support-solid-queue branch 2 times, most recently from edaee65 to 42e895a Compare June 1, 2026 10:16
@solnic solnic force-pushed the 2933-active-job-tracing-specs branch from 3eb29b0 to 6a62844 Compare June 9, 2026 11:09
@solnic solnic force-pushed the 2587-support-solid-queue branch from 42e895a to f1da26b Compare June 9, 2026 11:10
@solnic solnic force-pushed the 2933-active-job-tracing-specs branch from c9da666 to d072fd5 Compare June 12, 2026 09:36
@solnic solnic force-pushed the 2587-support-solid-queue branch 3 times, most recently from 951fdcb to d9baea2 Compare June 16, 2026 11:35
@solnic solnic force-pushed the 2933-active-job-tracing-specs branch from d65c086 to 49aa99c Compare June 22, 2026 08:02
@solnic solnic force-pushed the 2587-support-solid-queue branch from d9baea2 to f2c6e34 Compare June 22, 2026 08:02
@solnic solnic force-pushed the 2587-support-solid-queue branch from 0afc95a to c0bc241 Compare June 24, 2026 11:19
@solnic solnic marked this pull request as ready for review June 24, 2026 11:29

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c0bc241. Configure here.

ready = SolidQueue::ReadyExecution.claim("*", 100, process.id)
break if ready.empty? && SolidQueue::ScheduledExecution.none?
ready.each(&:perform)
end

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drain loop never terminates

Medium Severity

The drain loop only exits when the ready queue is empty and there are no rows in SolidQueue::ScheduledExecution. If scheduled rows exist but none are due yet (scheduled_at still in the future), dispatch_next_batch promotes nothing, claim returns an empty set, and the loop keeps spinning because scheduled rows remain.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c0bc241. Configure here.

SolidQueue::ScheduledExecution.dispatch_next_batch(100)
ready = SolidQueue::ReadyExecution.claim("*", 100, process.id)
break if ready.empty? && SolidQueue::ScheduledExecution.none?
ready.each(&:perform)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drain swallows job exceptions

High Severity

Calling perform on claimed Solid Queue executions returns a result object and rescues job failures instead of re-raising. The shared ActiveJob harness examples expect drain to propagate the same exceptions as ActiveJob::Base.execute, including for expect { drain }.to raise_error cases.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit c0bc241. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Solid Queue

1 participant