Add external_propagation_context support#2841
Conversation
|
sl0thentr0py
force-pushed
the
neel/external-prop-context
branch
from
5357278 to
36d557d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
sl0thentr0py
force-pushed
the
neel/external-prop-context
branch
from
36d557d to
bc26080
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| def apply_to_telemetry(telemetry) | ||
| # TODO-neel when new scope set_attribute api is added: add them here | ||
| trace_context = span ? span.get_trace_context : propagation_context.get_trace_context | ||
| trace_context = get_trace_context |
There was a problem hiding this comment.
This seems to be an overkill because we're building up a bunch of hashes just to get trace_id and span_id - it would be better to have something more dedicated to get these two values.
There was a problem hiding this comment.
its one hash, its fine because all these values belong together, they are not separate
There was a problem hiding this comment.
its one hash, its fine because all these values belong together, they are not separate
2 participants
Description
Needed for OTLP Integration.