fix(ios): [RN 0.87] remove unused React/RCTTextView.h import#6322
Draft
cortinico wants to merge 1 commit into
Draft
fix(ios): [RN 0.87] remove unused React/RCTTextView.h import#6322cortinico wants to merge 1 commit into
cortinico wants to merge 1 commit into
Conversation
RCTTextView.h was removed from React Native 0.87 as part of the legacy architecture removal (react/react-native#56831), breaking the iOS build with "'React/RCTTextView.h' file not found". The import was unused: RCTTextView is only referenced as a runtime string (@"RCTTextView") for Session Replay text masking, so no symbol from the header is needed. Removing the import keeps masking working on both old and new React Native versions (@"RCTParagraphComponentView" already covers Fabric).
Contributor
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
cortinico
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Important
This is needed for this library to work with RN 0.87. Please review/merge and publish a new version of the sentry library on NPM if possible.
packages/core/ios/RNSentryReplay.mmimportedReact/RCTTextView.h, which has been removed from React Native 0.87 as part of the legacy architecture cleanup (facebook/react-native#56831). This breaks the iOS build with:The import was unused —
RCTTextViewis only referenced as the runtime string@"RCTTextView"when building the Session Replay redaction class list, so no symbol from the header is needed (@"RCTParagraphComponentView"already covers the Fabric text view). Removing the import restores the build on RN 0.87 while keeping masking behavior identical on older RN versions.💡 Motivation and Context
React Native 0.87 (currently nightly) deleted
Libraries/Text/Text/RCTTextView.h, so any app using@sentry/react-nativefails to compile on iOS. Surfaced by the React Native community nightly tests.https://react-native-community.github.io/nightly-tests/
💚 How did you test it?
RCTTextViewis no longer referenced as a type/symbol anywhere inRNSentryReplay.mm; the only remaining usage is the string literal@"RCTTextView"for replay masking, which is unchanged.📝 Checklist
sendDefaultPIIis enabled