Skip to content

Size analysis for React Native SDK#5949

Merged
alwx merged 4 commits intomainfrom
alwx/ci/emerge-size-analysis
Apr 2, 2026
Merged

Size analysis for React Native SDK#5949
alwx merged 4 commits intomainfrom
alwx/ci/emerge-size-analysis

Conversation

@alwx
Copy link
Copy Markdown
Contributor

@alwx alwx commented Apr 2, 2026

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

Adds size analysis CI job based on what's already done in Dart SDK: getsentry/sentry-dart#3368
Also fixes #5333

📝 Checklist

  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • All tests passing
  • No breaking changes

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Semver Impact of This PR

None (no version bump detected)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


  • Size analysis for React Native SDK by alwx in #5949
  • chore(deps): bump brace-expansion to ^2.0.3 by antonis in #5951
  • chore(deps): bump @xmldom/xmldom to fix XML injection by antonis in #5952

🤖 This preview updates automatically when you update the PR.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 2, 2026

Fails
🚫 Pull request is not ready for merge, please add the "ready-to-merge" label to the pull request
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

### Features

- Size analysis for React Native SDK ([#5949](https://github.com/getsentry/sentry-react-native/pull/5949))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description or adding a skip-changelog label.

Generated by 🚫 dangerJS against d9b2873

@sentry
Copy link
Copy Markdown

sentry bot commented Apr 2, 2026

Sentry Build Distribution

App Name App ID Version Configuration Install Page
Sentry RN io.sentry.reactnative.sample 8.7.0 (82) Release Install Build

alwx added 2 commits April 2, 2026 11:42
…flow

The pod-install.sh script greps Podfile.lock for $RN_SENTRY_POD_NAME to
verify the Sentry pod was installed. Without this env var set, grep
receives an empty pattern and exits with code 2, failing the iOS job.

Set RN_SENTRY_POD_NAME=RNSentry in the workflow env block, matching the
sample-application.yml workflow.
@alwx alwx changed the title WIP: Size analysis for React Native SDK Size analysis for React Native SDK Apr 2, 2026
@alwx alwx marked this pull request as ready for review April 2, 2026 09:59
@alwx alwx self-assigned this Apr 2, 2026
Copy link
Copy Markdown
Contributor

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alwx
Copy link
Copy Markdown
Contributor Author

alwx commented Apr 2, 2026

Skipping ready-to-merge because here it's literally just a new CI workflow

@alwx alwx merged commit 553198a into main Apr 2, 2026
52 of 57 checks passed
@alwx alwx deleted the alwx/ci/emerge-size-analysis branch April 2, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrated Emerge's Size Analysis

2 participants