Fix(Replay): dont record ignored/dropped errors

CHANGELOG.md

@@ -10,6 +10,7 @@
 
 ### Fixes
 
+- Session replay will no longer start recording when an event was ignored or dropped. ([#5885](https://github.com/getsentry/sentry-react-native/pull/5885))
 - Fix SIGABRT crash on launch when `mobileReplayIntegration` is not configured and iOS deployment target >= 16.0 ([#5858](https://github.com/getsentry/sentry-react-native/pull/5858))
 - Reduce `reactNavigationIntegration` performance overhead ([#5840](https://github.com/getsentry/sentry-react-native/pull/5840), [#5842](https://github.com/getsentry/sentry-react-native/pull/5842), [#5849](https://github.com/getsentry/sentry-react-native/pull/5849))
 - Fix duplicated breadcrumbs on Android ([#5841](https://github.com/getsentry/sentry-react-native/pull/5841))

packages/core/src/js/replay/mobilereplay.ts

@@ -1,4 +1,4 @@
-import type { Client, DynamicSamplingContext, Event, EventHint, Integration, Metric } from '@sentry/core';
+import type { Client, DynamicSamplingContext, ErrorEvent, Event, EventHint, Integration, Metric } from '@sentry/core';
 import { debug } from '@sentry/core';
 import { isHardCrash } from '../misc';
 import { hasHooks } from '../utils/clientutils';
@@ -213,7 +213,7 @@ export const mobileReplayIntegration = (initOptions: MobileReplayOptions = defau
     return nativeReplayId;
   }
 
-  async function processEvent(event: Event, hint: EventHint): Promise<Event> {
+  async function processEvent(event: ErrorEvent, hint: EventHint): Promise<ErrorEvent> {
     const hasException = event.exception?.values && event.exception.values.length > 0;
     if (!hasException) {
       // Event is not an error, will not capture replay
@@ -303,6 +303,21 @@ export const mobileReplayIntegration = (initOptions: MobileReplayOptions = defau
     });
 
     client.on('beforeAddBreadcrumb', enrichXhrBreadcrumbsForMobileReplay);
+
+    // Wrap beforeSend to run processEvent after user's beforeSend
+    const clientOptions = client.getOptions();
+    const originalBeforeSend = clientOptions.beforeSend;
+    clientOptions.beforeSend = async (event: ErrorEvent, hint: EventHint): Promise<ErrorEvent | null> => {
+      var result = event;
+      if (originalBeforeSend) {
+        result = await originalBeforeSend(event, hint);
+        if (result === null) {
+          // Event was dropped by user's beforeSend, don't capture replay
+          return null;
+        }
+      }
+      return processEvent(result, hint);
+    };
   }
 
   function getReplayId(): string | null {
@@ -314,7 +329,6 @@ export const mobileReplayIntegration = (initOptions: MobileReplayOptions = defau
   return {
     name: MOBILE_REPLAY_INTEGRATION_NAME,
     setup,
-    processEvent,
     options: options,
     getReplayId: getReplayId,
   };