Skip to content

fix: Set transaction source for unsampled streamed spans #6250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
alexander-alderman-webb wants to merge 1 commit into from
+4 −3
Closed

fix: Set transaction source for unsampled streamed spans #6250

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions sentry_sdk/scope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -849,6 +849,10 @@ def transaction(self, value: "Any") -> None:
def set_transaction_name(self, name: str, source: "Optional[str]" = None) -> None:
"""Set the transaction name and optionally the transaction source."""
self._transaction = name

if source:
self._transaction_info["source"] = source

if self._span:
if isinstance(self._span, NoOpStreamedSpan):
return
Expand All @@ -865,9 +869,6 @@ def set_transaction_name(self, name: str, source: "Optional[str]" = None) -> Non
if source:
self._span.containing_transaction.source = source

if source:
self._transaction_info["source"] = source

@_attr_setter
def user(self, value: "Optional[Dict[str, Any]]") -> None:
"""When set a specific user is bound to the scope. Deprecated in favor of set_user."""
Expand Down
Loading