feat(tornado): Support span streaming#6206
Conversation
sl0thentr0py
changed the title
Codecov Results 📊✅ 13 passed | Total: 13 | Pass Rate: 100% | Execution Time: 12.65s All tests are passing successfully. ❌ Patch coverage is 6.52%. Project has 15088 uncovered lines. Files with missing lines (1)
Generated by Codecov Action |
sl0thentr0py
changed the title
alexander-alderman-webb
left a comment
alexander-alderman-webb
left a comment
There was a problem hiding this comment.
Comment not blocking, looks good to me!
| span.status = "error" if status_int >= 400 else "ok" | ||
|
|
||
|
|
||
| def _get_request_attributes(request: "Any") -> "Dict[str, Any]": |
There was a problem hiding this comment.
Are we still capturing the request body in the streaming path? See https://getsentry.github.io/sentry-conventions/attributes/http/#http-request-body-data
For prior art IIRC @ericapisani did this for another integration, not sure which exactly
| span.status = "error" if status_int >= 400 else "ok" | ||
|
|
||
|
|
||
| def _get_request_attributes(request: "Any") -> "Dict[str, Any]": |
Add span-streaming support to the Tornado integration. When span streaming is enabled, the request handler emits a StreamedSpan with HTTP request attributes (method, headers, query, URL, client address) and sets the response status on completion. The legacy transaction path is preserved for non-streaming mode. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
sl0thentr0py
force-pushed
the
neel/span-first/tornado
branch
from
82de412 to
a58538d
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 036b60a. Configure here.
4 participants
Issues