feat(metrics): add metric_flush_threshold flag#2059
Open
Litarnus wants to merge 1 commit intoringbuffer-for-logsfrom
Open
feat(metrics): add metric_flush_threshold flag#2059Litarnus wants to merge 1 commit intoringbuffer-for-logsfrom
metric_flush_threshold flag#2059Litarnus wants to merge 1 commit intoringbuffer-for-logsfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces the
metric_flush_thresholdflag which behaves the same as thelog_flush_thresholdflag, meaning that it will perform an automatic flush once the metric count is equal to the value configured inmetric_flush_threshold.This PR is deliberately pointed towards the
ringbuffer-for-logsbranch because it introduces theTelemetryStoragewhich is also used in this PR. Please review #2058 first, otherwise the current changes might not make that much sense. I will change the target tomasteronce the previous PR is mergedcloses PHP-75