build: Allow custom screenshot impl for downstream SDKs#1697
build: Allow custom screenshot impl for downstream SDKs#1697
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7083f91. Configure here.
| endif() | ||
|
|
||
| if(SENTRY_SCREENSHOT STREQUAL "windows") | ||
| set(SENTRY_SCREENSHOT_WINDOWS TRUE) |
There was a problem hiding this comment.
Missing WIN32 guard for windows screenshot option
Low Severity
The SENTRY_SCREENSHOT "windows" branch doesn't validate that it's actually running on WIN32, unlike the analogous SENTRY_TRANSPORT "winhttp" check which includes if(NOT WIN32) message(FATAL_ERROR ...). If a user explicitly passes -DSENTRY_SCREENSHOT=windows on a non-Windows platform, it would attempt to compile sentry_screenshot_windows.c with Windows-specific APIs, leading to confusing compilation errors rather than a clear configuration-time error.
Reviewed by Cursor Bugbot for commit 7083f91. Configure here.
Allow downstream SDKs to select SENTRY_SCREENSHOT=custom so sentry-native skips the built-in screenshot capture source and expects an implementation from the embedding build. Co-Authored-By: OpenAI Codex <noreply@openai.com>
7083f91 to
9b6b206
Compare


Allow downstream SDKs to select
SENTRY_SCREENSHOT=customso sentry-native skips the built-in screenshot capture source and expects an implementation from the embedding build.