fix(native): Fix smaller findings for Linux minidump writer#1694
Open
fix(native): Fix smaller findings for Linux minidump writer#1694
Conversation
b8a9319 to
5fd69fb
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6fca3dd. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

MD_LINUX_MAPSstream type (was tagged asMD_LINUX_AUXV)./dev/shm/*,(deleted)files) from the minidump module list.base_of_image. Fixes duplicateld-linuxentries that confused some debuggers (notably Windows LLDB) reading Linux ARM64 minidumps.uname()is blocked (sandbox/seccomp) and fall back to/proc/sys/kernel/osreleasefor the OS version.LinuxAuxv,LinuxCpuInfo,LinuxLsbRelease,LinuxCmdLine,LinuxEnviron, andLinuxDsoDebugstreams alongside the existing set. LLDB needsLinuxAuxvandLinuxDsoDebugto identify the dynamic loader and enumerate loaded shared libraries; without them, opening a minidump in LLDB on Linux would only recover one frame per thread.MemoryListStream. Previously stack bytes were only referenced from the per-thread record, so debuggers that look up memory by virtual address (LLDB) could not read the stack and unwinding stopped at frame 0 even wheneh_framewas available.