-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
WIP: Implement orchestrion-based instrumentation for vercel-ai v6 #21658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
mydea
wants to merge
1
commit into
fn/vercel-ai-v7
Choose a base branch
from
fn/try-orchestrion
base: fn/vercel-ai-v7
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
4 changes: 4 additions & 0 deletions
4
dev-packages/node-integration-tests/suites/tracing/vercelai/v6_v7/instrument-with-pii.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 4 additions & 0 deletions
4
dev-packages/node-integration-tests/suites/tracing/vercelai/v6_v7/instrument.mjs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
45 changes: 45 additions & 0 deletions
45
packages/node/src/integrations/tracing/vercelai/channel-integration.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,45 @@ | ||
| import type { Client, IntegrationFn } from '@sentry/core'; | ||
| import { defineIntegration } from '@sentry/core'; | ||
| import { tracingChannel as otelTracingChannel } from '@sentry/opentelemetry/tracing-channel'; | ||
| import { subscribeVercelAiOrchestrionChannels, subscribeVercelAiTracingChannel } from '@sentry/server-utils'; | ||
| import { INTEGRATION_NAME } from './constants'; | ||
|
|
||
| // In channel-based (orchestrion) mode we emit our own `gen_ai.*` spans from the | ||
| // diagnostics channels. The `ai` SDK still emits its own native OpenTelemetry | ||
| // spans whenever the user enables `experimental_telemetry`, which would be | ||
| // duplicates. Every native `ai` span carries an `ai.operationId` attribute | ||
| // (e.g. `ai.generateText`, `ai.generateText.doGenerate`, `ai.toolCall`) at span | ||
| // start, whereas our channel spans use `vercel.ai.operationId` — so we drop the | ||
| // native ones up front via `ignoreSpans`, before any vercel-ai processing runs. | ||
| const NATIVE_VERCEL_AI_SPANS = { attributes: { 'ai.operationId': /^ai\./ } }; | ||
|
|
||
| const _vercelAiChannelIntegration = (() => { | ||
| return { | ||
| name: INTEGRATION_NAME, | ||
| beforeSetup(client: Client) { | ||
| // Ensure we drop spans emitted by ai v6 or below | ||
| // To avoid double-instrumentation - in this scenario, we only want to rely on our own spans | ||
| const options = client.getOptions(); | ||
| options.ignoreSpans = [...(options.ignoreSpans || []), NATIVE_VERCEL_AI_SPANS]; | ||
| }, | ||
| setupOnce() { | ||
| // v7: subscribe to the `ai` SDK's native `ai:telemetry` tracing channel. | ||
| // No-op on versions that don't publish to it, so it is always safe to call. | ||
| // The factory needs the Sentry OTel context manager, which `initOpenTelemetry()` | ||
| // registers after `setupOnce`, so defer a tick. | ||
| void Promise.resolve().then(() => subscribeVercelAiTracingChannel(otelTracingChannel)); | ||
|
|
||
| // v6: there is no native channel — orchestrion injects `orchestrion:ai:*` | ||
| // channels which this adapter consumes via the same span core. Inert when | ||
| // orchestrion isn't active or on `ai` >= 7. | ||
| subscribeVercelAiOrchestrionChannels(); | ||
| }, | ||
| }; | ||
| }) satisfies IntegrationFn; | ||
|
|
||
| /** | ||
| * Adds Sentry tracing instrumentation for the [ai](https://www.npmjs.com/package/ai) library via | ||
| * diagnostics channels — the channel-based counterpart to the OpenTelemetry `vercelAIIntegration`, | ||
| * used when diagnostics-channel injection is opted into. | ||
| */ | ||
| export const vercelAiChannelIntegration = defineIntegration(_vercelAiChannelIntegration); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing v6 orchestrion E2E coverage
Low Severity
This feature adds orchestrion-based Vercel AI v6 instrumentation, but the integration matrix only enables
USE_ORCHESTRIONfor AI v7. AI v6 with orchestrion—the main new subscriber path—is not exercised by the E2E suite.Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit 3417464. Configure here.