ref(node): Streamline kafkajs instrumentation#21647
Merged
Merged
Conversation
Streamlines the vendored kafkajs instrumentation onto Sentry's span APIs. Span creation moves from the OTel tracer to `startInactiveSpan`/`withActiveSpan`, and cross-broker trace propagation now uses `getTraceData` (producer inject) and `continueTrace` (consumer `eachMessage`) instead of the OTel propagator, so the vendored `bufferTextMapGetter` is gone. The batch (`eachBatch`) path keeps the upstream shape: the `poll` span is a fresh root and each processed message links back to its producer span. The four OTel metrics (no MeterProvider is wired up) and the `network.request` event listeners that only fed them are dropped, along with `recordException` and the producer/consumer hooks (origin is folded into span creation instead). Helpers are extracted into a `utils.ts` and the now-trivial `types.ts`/`internal-types.ts` are removed. Adds a real error-path scenario to the integration suite asserting the producer span is marked errored when a send fails.
logaretm
requested review from
JPeer264 and
mydea
and removed request for
a team
Contributor
size-limit report 📦
|
logaretm
requested review from
andreiborza,
isaacs and
nicohrubec
and removed request for
mydea
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Streamlines the vendored kafkajs instrumentation onto Sentry's span APIs.
closes #20732