Skip to content

ci: Dedup flaky test issues across esm/cjs variants #21595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicohrubec merged 2 commits into from
Jun 17, 2026
+22 −5
Merged

ci: Dedup flaky test issues across esm/cjs variants #21595

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
46395bd
fix(ci): Dedup flaky test issues across esm/cjs variants
nicohrubec Jun 17, 2026
582573b
fix(ci): Key issue title and logs on the normalized test name
nicohrubec Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 22 additions & 5 deletions scripts/report-ci-failures.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,20 @@ function normalizeJobName(name) {
.trim();
}

/**
* Collapse esm/cjs variants of a test name so the same test failing in both module formats dedupes
* to a single issue instead of one per variant:
*
* "... > esm/cjs > esm > should send messages" -> "... > esm/cjs > should send messages"
* "... > esm/cjs > cjs > should send messages" -> "... > esm/cjs > should send messages"
*/
function normalizeTestName(name) {
return name
.replace(/esm\/cjs\s*>\s*(?:esm|cjs)\b/gi, 'esm/cjs')
.replace(/\s+/g, ' ')
.trim();
}
Comment thread
nicohrubec marked this conversation as resolved.

function applyVars(text, vars) {
let result = text;
for (const [key, value] of Object.entries(vars)) {
Expand Down Expand Up @@ -108,9 +122,12 @@ export default async function run({ github, context, core }) {

// Create one issue per failing test for proper deduplication
for (const testName of testNames) {
// The title is keyed on the *normalized* job name so the same test failing across matrix
// variants (different node / TS versions) dedupes to a single issue.
const title = applyVars(titleTemplate, { JOB_NAME: normalizedJobName, TEST_NAME: testName });
const normalizedTestName = normalizeTestName(testName);

// The title is keyed on the *normalized* job name + test name so the same test failing across
// matrix variants (different node / TS versions) or module formats (esm / cjs) dedupes to a
// single issue.
const title = applyVars(titleTemplate, { JOB_NAME: normalizedJobName, TEST_NAME: normalizedTestName });
// The body keeps the concrete job name + run link of the variant that actually failed.
const issueBody = applyVars(bodyTemplate, { JOB_NAME: jobName, RUN_LINK: jobUrl, TEST_NAME: testName });

Expand All @@ -121,7 +138,7 @@ export default async function run({ github, context, core }) {

const existingIssue = existing.find(i => i.title === title);
if (existingIssue) {
core.info(`Issue already exists for "${testName}" in ${normalizedJobName}: #${existingIssue.number}`);
core.info(`Issue already exists for "${normalizedTestName}" in ${normalizedJobName}: #${existingIssue.number}`);
continue;
}

Expand All @@ -132,7 +149,7 @@ export default async function run({ github, context, core }) {
body: issueBody.trim(),
labels: ['Tests', 'Bug', 'Flaky Test'],
});
core.info(`Created issue #${newIssue.data.number} for "${testName}" in ${normalizedJobName}`);
core.info(`Created issue #${newIssue.data.number} for "${normalizedTestName}" in ${normalizedJobName}`);
}
}
}
Loading