ref(node): Use Sentry span APIs in vendored connect instrumentation#21529
Merged
Conversation
Replace the OTel tracer/context span lifecycle with `startInactiveSpan` from `@sentry/core`, and mark middleware spans as errored (throw or `next(err)`). Swap the remaining `diag.warn` for the Sentry debug logger. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
size-limit report 📦
|
Move the Sentry op/origin/name off the `addConnectSpanAttributes` spanStart hook into the `startInactiveSpan` call, so they're set unconditionally (the hook only ran when `setupConnectErrorHandler` was used). Drop the now-unused `ConnectNames` enum and the hook. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
Author
|
Folded into #21404 via fast-forward merge into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #21404.
Migrates the vendored connect instrumentation off the OTel tracer/context APIs to
startInactiveSpanfrom@sentry/core(the faithful fit for connect's create-now / end-on-next()-or-res-close, non-active span lifecycle), and replaces the last@opentelemetry/apiruntime usage (diag.warn) with the Sentry debug logger.Also marks middleware spans as
internal_errorwhen the middleware errors — either by throwing (caught around the middleware invocation) or by callingnext(err). This is a small behavior improvement over upstream OTel connect (which never set status), consistent with the generic-pool and fastify/nestjs instrumentations. Adds an assertion that the/errorrequest_handler span isinternal_error.