WIP feat(opentelemetry): Add SentryTraceProvider#21181
Draft
andreiborza wants to merge 9 commits into
Draft
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
0f2020a to
71e7c69
Compare
mydea
reviewed
May 27, 2026
| */ | ||
| public recordException(_exception: unknown, _time?: number | undefined): void { | ||
| // noop | ||
| public recordException(exception: unknown, time?: SpanTimeInput | undefined): void { |
Member
There was a problem hiding this comment.
I think we can leave this as noop, we do not care about this and do not really support it, doing nothing with events etc.
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
71e7c69 to
a44215e
Compare
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
cf369b6 to
749e7e7
Compare
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
6 times, most recently
from
8ebaf6b to
2b70730
Compare
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
959483b to
87ed1f0
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5917bab. Configure here.
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
3 times, most recently
from
d265e00 to
34725df
Compare
`SentrySpan.updateName()` stamps `sentry.source: 'custom'` unconditionally again (as on develop), except for spans branded via `markSpanForOtelSourceInference()`. SentryTraceProvider sets that brand on the spans it creates, so instrumentations renaming them don't pin 'custom' and `applyOtelSpanData` can infer the correct source (e.g. 'route', 'task') at span end — mirroring OTel SDK spans, which carry no Sentry source concept. This replaces the earlier "only set custom when a source already exists" heuristic, which also unintentionally stopped stamping 'custom' on user-created child spans that start without a source. Branding scopes the carve-out to exactly the provider-created spans. Standalone this commit is develop-equivalent (nothing sets the brand yet); the follow-up SentryTraceProvider PR flips it on. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a minimal OpenTelemetry `TracerProvider` that creates native Sentry spans instead of bridging through the full OTel SDK. Includes the `SentryTracer`, `applyOtelSpanData` OTel-to-Sentry inference, sampling-decision propagation via the span context, and supporting changes to the async context strategy, setup checks, and DSC/root-span-name enhancement. Exposed for wiring via `_INTERNAL_startInactiveSpan` in core. Gated behind the consumer SDK and has no effect until enabled there. Co-Authored-By: Claude <noreply@anthropic.com>
Add the `useSentryTraceProvider` experimental option and the Node setup path that registers the `SentryTraceProvider` (and its async context strategy) instead of the full OpenTelemetry SDK tracer provider when enabled. Skips the `SentrySpanProcessor`/`SentrySampler` setup that the provider replaces, guards the HTTP server-spans integration for the missing async-local-storage lookup, and finalizes span data on `spanEnd`. Defaults to off. Co-Authored-By: Claude <noreply@anthropic.com>
andreiborza
force-pushed
the
ab/sentry-tracer-provider
branch
from
916e70a to
a6caf6a
Compare
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
…eeded Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP