fix(node-core): Guard against undefined util.getSystemErrorMap#20660
fix(node-core): Guard against undefined util.getSystemErrorMap#20660sentry[bot] wants to merge 1 commit intodevelopfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d147bf4. Configure here.
| // https://github.com/nodejs/node/issues/46869 | ||
| if (typeof util.getSystemErrorMap !== 'function') { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Fix PR missing regression test for the guard
Low Severity
This fix PR adds a typeof guard for util.getSystemErrorMap but does not include any unit, integration, or e2e test verifying that isSystemError returns false when util.getSystemErrorMap is undefined. A regression test mocking util.getSystemErrorMap as undefined would confirm the fix works and prevent future regressions.
Triggered by project rule: PR Review Guidelines for Cursor Bot
Reviewed by Cursor Bugbot for commit d147bf4. Configure here.
There was a problem hiding this comment.
Adding a small unit test would be great I think :) I just noticed there are none yet but it should go in packages/node-core/test/integrations/systemError.test.ts.
size-limit report 📦
|
nicohrubec
left a comment
nicohrubec
left a comment
There was a problem hiding this comment.
Change lgtm! I agree with cursor that a small test would be good to catch future regressions, but else I think this is good to merge from my side.
| // https://github.com/nodejs/node/issues/46869 | ||
| if (typeof util.getSystemErrorMap !== 'function') { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
Adding a small unit test would be great I think :) I just noticed there are none yet but it should go in packages/node-core/test/integrations/systemError.test.ts.
2 participants
The
systemErrorIntegrationin@sentry/node-coreattempts to callutil.getSystemErrorMap()to determine if an error is a Node.js SystemError. However, in environments like Bun (which provides a Node.js compatibility layer),util.getSystemErrorMapmay be undefined.This leads to a
TypeError: util.getSystemErrorMap is not a functionwhen Sentry tries to process any event, effectively crashing the Sentry event pipeline.This change adds a
typeofcheck forutil.getSystemErrorMapwithin theisSystemErrorfunction. If the function is not available,isSystemErrorwill now gracefully returnfalse, preventing theTypeErrorand allowing Sentry's event processing to continue. This means that system error context enrichment will be skipped in environments where this specificutilAPI is missing, which is the desired fallback behavior.See also: oven-sh/bun#22872
Fixes XCODEBUILDMCP-1J