ref(nuxt): Extract core logic for storage/database to prepare for Nuxt v5 #19920
Open
s1gr1d wants to merge 1 commit intosig/nuxt-v5-handlerfrom
Open
ref(nuxt): Extract core logic for storage/database to prepare for Nuxt v5 #19920s1gr1d wants to merge 1 commit intosig/nuxt-v5-handlerfrom
s1gr1d wants to merge 1 commit intosig/nuxt-v5-handlerfrom
Conversation
Contributor
Semver Impact of This PR🟢 Patch (bug fixes) 📋 Changelog PreviewThis is how your changes will appear in the changelog. New Features ✨Deps
Bug Fixes 🐛
Internal Changes 🔧Nuxt
Other
🤖 This preview updates automatically when you update the PR. |
c39b5a4 to
d059df3
Compare
Contributor
size-limit report 📦
|
logaretm
approved these changes
Mar 20, 2026
Member
logaretm
left a comment
There was a problem hiding this comment.
LGTM, I hope Nitro releases the tracing version soon and we can then tell Daniel to use it so we can avoid having most of this code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nitrodev dependency): #19913Following the same pattern established for the H3 event handler, the database and storage instrumentation logic has been extracted from the plugin entry points into shared utility functions (
instrumentDatabase.ts,instrumentStorage.ts).Closes #19916