Skip to content

ref(nuxt): Extract core logic for storage/database to prepare for Nuxt v5 #19920

Open
s1gr1d wants to merge 1 commit intosig/nuxt-v5-handlerfrom
sig/nuxt-5-storage
Open

ref(nuxt): Extract core logic for storage/database to prepare for Nuxt v5 #19920
s1gr1d wants to merge 1 commit intosig/nuxt-v5-handlerfrom
sig/nuxt-5-storage

Conversation

@s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Mar 20, 2026

⚠️ First merge (includes nitro dev dependency): #19913

Following the same pattern established for the H3 event handler, the database and storage instrumentation logic has been extracted from the plugin entry points into shared utility functions (instrumentDatabase.ts, instrumentStorage.ts).

Closes #19916

@github-actions
Copy link
Contributor

github-actions bot commented Mar 20, 2026

Semver Impact of This PR

🟢 Patch (bug fixes)

📋 Changelog Preview

This is how your changes will appear in the changelog.
Entries from this PR are highlighted with a left border (blockquote style).


New Features ✨

Deps

  • Bump mongodb-memory-server-global from 10.1.4 to 11.0.1 by dependabot in #19888
  • Bump stacktrace-parser from 0.1.10 to 0.1.11 by dependabot in #19887

Bug Fixes 🐛

  • (cloudflare) Forward ctx argument to Workflow.do user callback by Lms24 in #19891
  • (core) Return same value from startSpan as callback returns by s1gr1d in #19300
  • (deps) Bump socket.io-parser to 4.2.6 to fix CVE-2026-33151 by chargome in #19880
  • (nestjs) Add node to nest metadata by chargome in #19875
  • (serverless) Add node to metadata by nicohrubec in #19878

Internal Changes 🔧

Nuxt

  • Extract core logic for storage/database to prepare for Nuxt v5 by s1gr1d in #19920
  • Extract handler patching to extra plugin for Nitro v2/v3 by s1gr1d in #19915

Other

  • (astro) Re-enable server island tracing e2e test in Astro 6 by Lms24 in #19872
  • (lint) Resolve oxlint warnings by isaacs in #19893
  • (node-integration-tests) Remove unnecessary file-type dependency by Lms24 in #19824
  • (sveltekit) Replace recast + @babel/parser with acorn by roli-lpci in #19533

🤖 This preview updates automatically when you update the PR.

…19903)

We set the conversation id unconditionally based on the `resonse_id`, so
if a user calls `Sentry.setConversationId()` explicitly this will
be overwritten, which is unexpected.

Closes #19904 (added automatically)
@s1gr1d s1gr1d force-pushed the sig/nuxt-5-storage branch from c39b5a4 to d059df3 Compare March 20, 2026 14:21
@s1gr1d s1gr1d changed the title ref(nuxt): Extract core logic for storage/database to support Nuxt v4 and v5 ref(nuxt): Extract core logic for storage/database to prepare for Nuxt v5 Mar 20, 2026
@s1gr1d s1gr1d requested a review from logaretm March 20, 2026 14:21
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 25.69 kB added added
@sentry/browser - with treeshaking flags 24.17 kB added added
@sentry/browser (incl. Tracing) 42.67 kB added added
@sentry/browser (incl. Tracing, Profiling) 47.33 kB added added
@sentry/browser (incl. Tracing, Replay) 81.48 kB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 71.06 kB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 86.17 kB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 98.41 kB added added
@sentry/browser (incl. Feedback) 42.48 kB added added
@sentry/browser (incl. sendFeedback) 30.35 kB added added
@sentry/browser (incl. FeedbackAsync) 35.4 kB added added
@sentry/browser (incl. Metrics) 26.96 kB added added
@sentry/browser (incl. Logs) 27.1 kB added added
@sentry/browser (incl. Metrics & Logs) 27.78 kB added added
@sentry/react 27.45 kB added added
@sentry/react (incl. Tracing) 45.01 kB added added
@sentry/vue 30.13 kB added added
@sentry/vue (incl. Tracing) 44.52 kB added added
@sentry/svelte 25.7 kB added added
CDN Bundle 28.35 kB added added
CDN Bundle (incl. Tracing) 43.57 kB added added
CDN Bundle (incl. Logs, Metrics) 29.22 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) 44.43 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) 68.29 kB added added
CDN Bundle (incl. Tracing, Replay) 80.41 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 81.31 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 85.97 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 86.86 kB added added
CDN Bundle - uncompressed 82.7 kB added added
CDN Bundle (incl. Tracing) - uncompressed 128.62 kB added added
CDN Bundle (incl. Logs, Metrics) - uncompressed 85.57 kB added added
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 131.49 kB added added
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 209.22 kB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 245.5 kB added added
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 248.35 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 258.41 kB added added
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 261.26 kB added added
@sentry/nextjs (client) 47.4 kB added added
@sentry/sveltekit (client) 43.12 kB added added
@sentry/node-core 56.42 kB added added
@sentry/node 173.37 kB added added
@sentry/node - without tracing 96.43 kB added added
@sentry/aws-serverless 113.44 kB added added

Copy link
Member

@logaretm logaretm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I hope Nitro releases the tracing version soon and we can then tell Daniel to use it so we can avoid having most of this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants