feat(react-router): Include middleware function names and indices#19109
Open
onurtemizkan wants to merge 5 commits intodevelopfrom
Open
feat(react-router): Include middleware function names and indices#19109onurtemizkan wants to merge 5 commits intodevelopfrom
onurtemizkan wants to merge 5 commits intodevelopfrom
Conversation
Contributor
Codecov Results 📊Generated by Codecov Action |
onurtemizkan
force-pushed
the
onur/react-router-middleware-names
branch
from
de6be28 to
4c6cef9
Compare
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
onurtemizkan
force-pushed
the
onur/react-router-middleware-names
branch
from
b2182e1 to
d47508b
Compare
onurtemizkan
force-pushed
the
onur/react-router-middleware-names
branch
from
851f1e1 to
7484acb
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
packages/react-router/src/server/instrumentation/reactRouter.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #19097
Middleware spans created by the instrumentation API were using the route pattern as the span name (same as loaders and actions), which doesn't help when a route has multiple middlewares.
This PR adds function name resolution so middleware spans are named
middleware authMiddlewareinstead of just the route pattern. Each span also gets areact_router.middleware.indexattribute. When names are not available (anonymous arrow functions), it falls back to the route ID.Function names are resolved from the
ServerBuildobject, which is captured through two complementary paths:The OTEL instrumentation patches createRequestHandler at runtime, capturing the
ServerBuildfrom its arguments. This handles both static builds and factory functions (dev mode HMR).New Vite plugin (makeServerBuildCapturePlugin) that injects into the virtual react-router/server-build module during SSR builds, providing early capture at module initialization. This is needed because virtual modules are not reachable by OTEL's module hooks.
The
isInstrumentationApiUsed()check in the OTEL instrumentation was moved from the per-request handler tocreateRequestHandleritself. The OTEL hook now always needs to run to capture the ServerBuild reference for middleware name lookup; per-request wrapping is gated at the handler level instead. The Node version gating for the OTEL hook was also removed since it needs to run unconditionally now.Limitation: