Skip to content

ci(release): Switch from action-prepare-release to Craft #18763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BYK wants to merge 26 commits into
base: develop
Choose a base branch
from
+26 −3
Open

ci(release): Switch from action-prepare-release to Craft #18763

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
b9ae430
ci(release): Switch from action-prepare-release to Craft
BYK Jan 9, 2026
3c240d2
ci(release): Restore GitHub App token authentication
BYK Jan 9, 2026
f101fbf
ci(release): Restore GitHub App token authentication
BYK Jan 9, 2026
a8c5f38
fix: Pin actions to SHA and add permissions blocks
BYK Jan 10, 2026
95d4e72
fix: Restore PR trigger and version extraction for auto-release
BYK Jan 10, 2026
f88812d
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
d17ff7e
fix: Use correct action version SHAs (restore original versions)
BYK Jan 10, 2026
a902463
fix: Address review feedback (inputs context, permissions, triggers)
BYK Jan 10, 2026
5348f80
fix: Add Node.js setup to release workflow
BYK Jan 10, 2026
e912696
fix: Clean up action version comments
BYK Jan 12, 2026
480fe95
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK Jan 13, 2026
91807f2
Update Craft SHA to 1c58bfd57bfd6a967b6f3fc92bead2c42ee698ce
BYK Jan 13, 2026
fbb531f
Add explicit permissions block to build.yml
BYK Jan 13, 2026
b4ba2d3
Add explicit permissions block to codeql-analysis.yml
BYK Jan 13, 2026
e07b23e
Add explicit permissions block to create-issue-for-unreferenced-prs.yml
BYK Jan 13, 2026
c15b599
Add explicit permissions block to enforce-license-compliance.yml
BYK Jan 13, 2026
e26bc72
Revert permissions changes to build.yml
BYK Jan 13, 2026
df2832a
Revert permissions changes to codeql-analysis.yml
BYK Jan 13, 2026
657b2e0
Revert permissions changes to create-issue-for-unreferenced-prs.yml
BYK Jan 13, 2026
64e73aa
Revert permissions changes to enforce-license-compliance.yml
BYK Jan 13, 2026
0b2d1e4
fix: revert extraneous changes to non-release workflow files
BYK Jan 14, 2026
6855820
fix: clean up release.yml formatting and version comments
BYK Jan 14, 2026
0ad41f4
build(craft): Update Craft action to c6e2f04
BYK Jan 14, 2026
ec4ad57
chore: add unlabeled trigger to changelog-preview
BYK Jan 14, 2026
155069d
Update to latest standards
BYK Feb 12, 2026
5867289
Merge branch 'develop' into ci/migrate-to-craft-action
BYK Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
name: Changelog Preview
on:
pull_request_target:
types:
- opened
- synchronize
- reopened
- edited
- labeled
- unlabeled
permissions:
contents: write
pull-requests: write
statuses: write

jobs:
changelog-preview:
uses: getsentry/craft/.github/workflows/changelog-preview.yml@v2
secrets: inherit
10 changes: 7 additions & 3 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,15 +3,19 @@ on:
workflow_dispatch:
inputs:
version:
description: Version to release
required: true
description: Version to release (or "auto")
required: false
force:
description: Force a release even when there are release-blockers (optional)
required: false
merge_target:
description: Target branch to merge into. Uses the default branch as a fallback (optional)
required: false
default: master
permissions:
contents: write
pull-requests: write

jobs:
release:
runs-on: ubuntu-24.04
Expand All @@ -32,7 +36,7 @@ jobs:
with:
node-version-file: 'package.json'
- name: Prepare release
uses: getsentry/action-prepare-release@v1
uses: getsentry/craft@5d154a7facb096e38889be2c6caf2fd23649aa92# v2
Copy link

@cursor cursor bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing space before comment makes ref invalid

High Severity

The uses value getsentry/craft@5d154a7facb096e38889be2c6caf2fd23649aa92# v2 is missing a space before #. In YAML, # only starts a comment when preceded by whitespace. Without the space, # v2 becomes part of the ref string, resulting in the invalid git ref 5d154a7facb096e38889be2c6caf2fd23649aa92# v2. This will cause the release workflow to fail every time. Compare with line 26 which correctly uses a space: ...f6c875baf # v2.2.1.

Fix in Cursor Fix in Web

env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
Comment on lines 36 to 42
Copy link

@sentry sentry bot Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The auto-release.yml workflow was not migrated to the new Craft action and still uses the deprecated getsentry/action-prepare-release@v1, contrary to the PR's description.
Severity: HIGH

Suggested Fix

Update the .github/workflows/auto-release.yml file to use the new Craft reusable workflow, similar to the changes made in .github/workflows/release.yml. This will ensure both manual and automated release processes are consistent and no longer rely on the deprecated getsentry/action-prepare-release@v1 action.

Prompt for AI Agent 
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/release.yml#L36-L42

Potential issue: The pull request claims to migrate release workflows to the new Craft
action, but the `auto-release.yml` file was not updated. This file, which triggers an
automated release process when a `prepare-release/*` branch is merged, continues to use
the deprecated `getsentry/action-prepare-release@v1` action. This creates an
inconsistency with the manually triggered `release.yml` workflow, which was correctly
updated. The continued use of the deprecated action poses a risk of failure for the
automated release process if the action is removed or becomes unmaintained.

Did we get this right? 👍 / 👎 to inform future reviews.

Expand Down
Loading