Skip to content

test(spring-boot-jakarta): [Queue Instrumentation 22] Cover spring-kafka class-absence gate #5318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
adinauer wants to merge 1 commit into
base: fix/queue-instrumentation-kafka-preserve-baggage
Choose a base branch
from
+14 −0
Draft

test(spring-boot-jakarta): [Queue Instrumentation 22] Cover spring-kafka class-absence gate #5318

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions ...jakarta/src/test/kotlin/io/sentry/spring/boot/jakarta/SentryKafkaAutoConfigurationTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import org.assertj.core.api.Assertions.assertThat
import org.springframework.boot.autoconfigure.AutoConfigurations
import org.springframework.boot.test.context.FilteredClassLoader
import org.springframework.boot.test.context.runner.ApplicationContextRunner
import org.springframework.kafka.core.KafkaTemplate

class SentryKafkaAutoConfigurationTest {

Expand All @@ -34,6 +35,8 @@ class SentryKafkaAutoConfigurationTest {
private val noSentryKafkaClassLoader =
FilteredClassLoader(SentryKafkaProducerInterceptor::class.java)

private val noSpringKafkaClassLoader = FilteredClassLoader(KafkaTemplate::class.java)

@Test
fun `registers Kafka BPPs when queue tracing is enabled`() {
contextRunner
Expand Down Expand Up @@ -64,6 +67,17 @@ class SentryKafkaAutoConfigurationTest {
}
}

@Test
fun `does not register Kafka BPPs when spring-kafka is not present`() {
contextRunner
.withClassLoader(noSpringKafkaClassLoader)
.withPropertyValues("sentry.enable-queue-tracing=true")
.run { context ->
assertThat(context).doesNotHaveBean(SentryKafkaProducerBeanPostProcessor::class.java)
assertThat(context).doesNotHaveBean(SentryKafkaConsumerBeanPostProcessor::class.java)
}
}

@Test
fun `does not register Kafka BPPs when queue tracing is explicitly false`() {
contextRunner
Expand Down
Loading