Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,13 @@
import io.sentry.util.SpanUtils;
import io.sentry.util.TracingUtils;
import java.nio.charset.StandardCharsets;
import java.util.ArrayList;
import java.util.List;
import java.util.Map;
import org.apache.kafka.clients.producer.ProducerInterceptor;
import org.apache.kafka.clients.producer.ProducerRecord;
import org.apache.kafka.clients.producer.RecordMetadata;
import org.apache.kafka.common.header.Header;
import org.apache.kafka.common.header.Headers;
import org.jetbrains.annotations.ApiStatus;
import org.jetbrains.annotations.NotNull;
Expand Down Expand Up @@ -97,8 +100,10 @@ public void close() {}
public void configure(final @Nullable Map<String, ?> configs) {}

private void injectHeaders(final @NotNull Headers headers, final @NotNull ISpan span) {
final @Nullable List<String> existingBaggageHeaders =
readHeaderValues(headers, BaggageHeader.BAGGAGE_HEADER);
final @Nullable TracingUtils.TracingHeaders tracingHeaders =
TracingUtils.trace(scopes, null, span);
TracingUtils.trace(scopes, existingBaggageHeaders, span);
if (tracingHeaders != null) {
final @NotNull SentryTraceHeader sentryTraceHeader = tracingHeaders.getSentryTraceHeader();
headers.remove(sentryTraceHeader.getName());
Expand All @@ -120,4 +125,19 @@ private void injectHeaders(final @NotNull Headers headers, final @NotNull ISpan
String.valueOf(DateUtils.millisToSeconds(System.currentTimeMillis()))
.getBytes(StandardCharsets.UTF_8));
}

private static @Nullable List<String> readHeaderValues(
final @NotNull Headers headers, final @NotNull String name) {
@Nullable List<String> values = null;
for (final @NotNull Header header : headers.headers(name)) {
final byte @Nullable [] value = header.value();
if (value != null) {
if (values == null) {
values = new ArrayList<>();
}
values.add(new String(value, StandardCharsets.UTF_8));
}
}
return values;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package io.sentry.kafka

import io.sentry.BaggageHeader
import io.sentry.IScopes
import io.sentry.ISentryLifecycleToken
import io.sentry.Sentry
Expand Down Expand Up @@ -79,6 +80,37 @@ class SentryKafkaProducerInterceptorTest {
assertTrue(enqueuedTime > 0)
}

@Test
fun `preserves pre-existing third-party baggage header entries`() {
val tx = createTransaction()
val interceptor = SentryKafkaProducerInterceptor<String, String>(scopes)
val record = ProducerRecord<String, String>("my-topic", "key", "value")
record
.headers()
.add(
BaggageHeader.BAGGAGE_HEADER,
"othervendor=someValue,another=thing".toByteArray(StandardCharsets.UTF_8),
)

interceptor.onSend(record)

val baggageHeaders = record.headers().headers(BaggageHeader.BAGGAGE_HEADER).toList()
assertEquals(1, baggageHeaders.size)
val baggageValue = String(baggageHeaders.first().value(), StandardCharsets.UTF_8)
assertTrue(
baggageValue.contains("othervendor=someValue"),
"expected third-party baggage entry preserved, got: $baggageValue",
)
assertTrue(
baggageValue.contains("another=thing"),
"expected third-party baggage entry preserved, got: $baggageValue",
)
assertTrue(
baggageValue.contains("sentry-"),
"expected Sentry baggage entries appended, got: $baggageValue",
)
}

@Test
fun `does not create span when queue tracing is disabled`() {
val tx = createTransaction()
Expand Down
Loading