test: make tests independent of zip encoding#3239
Open
supervacuus wants to merge 2 commits intogetsentry:masterfrom
Open
test: make tests independent of zip encoding#3239supervacuus wants to merge 2 commits intogetsentry:masterfrom
supervacuus wants to merge 2 commits intogetsentry:masterfrom
Conversation
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extracted from #3237
This change was triggered by bumping
symbolicto12.17.3to include getsentry/symbolic#960.symbolicupdated itszipdependency (2.4.2to7.2.0) since the last bump. This changed encoding internals and invalidated a bunch of test assertions.The PR addresses the issue in the following way:
I rewrote the affected tests so that they decode the incoming chunks and compare their contents against the fixtures, rather than snapshotting, which could break with every change to the encoder. I also simplified the usage of
split_chunk_body()a bit: now it returns aVec, and callers decide how they want to view the data: the simple tests collect into aHashSetfor set comparison, while the small-chunk tests use aSHA1digest multimap to verify exact chunk identity and multiplicity.If you actually wanted an early warning whether the encoding was stable, then we can drop this PR.
Specifically, for
build_deterministic()insrc/utils/source_bundle.rs, it was not entirely clear whether you want two runs of the same version to have predictably the same output (which I changed it to) or whether it should actually be stable across future versions (which azipcrate bump upstream would break).Issues
Raised as part of the fix proposals for getsentry/sentry#104738
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.