-
-
Notifications
You must be signed in to change notification settings - Fork 240
feat(build): Add build download command
#3221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
runningcode
wants to merge
4
commits into
master
Choose a base branch
from
no/build-download
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
551c53d
feat(build): Add `build download` command (EME-272)
runningcode 38241aa
docs(changelog): Add entry for build download command
runningcode fc5832a
fix(build): Error on unsupported download format
runningcode f79f33d
fix(build): Use expect instead of unwrap for clippy
runningcode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| use std::fs; | ||
| use std::path::PathBuf; | ||
|
|
||
| use anyhow::{bail, Result}; | ||
| use clap::{Arg, ArgMatches, Command}; | ||
| use log::info; | ||
|
|
||
| use crate::api::Api; | ||
| use crate::config::Config; | ||
| use crate::utils::args::ArgExt as _; | ||
| use crate::utils::fs::TempFile; | ||
|
|
||
| pub fn make_command(command: Command) -> Command { | ||
| command | ||
| .about("Download a build from a project.") | ||
| .long_about("Download a build from a project.\n\nThis feature only works with Sentry SaaS.") | ||
| .org_arg() | ||
| .project_arg(false) | ||
| .arg( | ||
| Arg::new("build_id") | ||
| .long("build-id") | ||
| .short('b') | ||
| .required(true) | ||
| .help("The ID of the build to download."), | ||
| ) | ||
| .arg(Arg::new("output").long("output").help( | ||
szokeasaurusrex marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| "The output file path. Defaults to \ | ||
| 'preprod_artifact_<build_id>.<ext>' in the current directory, \ | ||
| where ext is ipa or apk depending on the platform.", | ||
| )) | ||
| } | ||
|
|
||
| /// For iOS builds, the install URL points to a plist manifest. | ||
| /// Replace the response_format to download the actual IPA binary instead. | ||
| fn ensure_binary_format(url: &str) -> String { | ||
| url.replace("response_format=plist", "response_format=ipa") | ||
| } | ||
|
|
||
| /// Extract the file extension from the response_format query parameter. | ||
| fn extension_from_url(url: &str) -> Result<&str> { | ||
| if url.contains("response_format=ipa") { | ||
| Ok("ipa") | ||
| } else if url.contains("response_format=apk") { | ||
| Ok("apk") | ||
| } else { | ||
| bail!("Unsupported build format in download URL.") | ||
| } | ||
| } | ||
|
|
||
| pub fn execute(matches: &ArgMatches) -> Result<()> { | ||
| let config = Config::current(); | ||
| let org = config.get_org(matches)?; | ||
| let build_id = matches | ||
| .get_one::<String>("build_id") | ||
| .expect("build_id is required"); | ||
|
|
||
| let api = Api::current(); | ||
| let authenticated_api = api.authenticated()?; | ||
|
|
||
| info!("Fetching install details for build {build_id}"); | ||
| let details = authenticated_api.get_build_install_details(&org, build_id)?; | ||
|
|
||
| if !details.is_installable { | ||
| bail!("Build {build_id} is not installable."); | ||
| } | ||
|
|
||
| let install_url = details | ||
| .install_url | ||
| .ok_or_else(|| anyhow::anyhow!("Build {build_id} has no install URL."))?; | ||
|
|
||
| let download_url = ensure_binary_format(&install_url); | ||
|
|
||
| let output_path = match matches.get_one::<String>("output") { | ||
| Some(path) => PathBuf::from(path), | ||
| None => { | ||
| let ext = extension_from_url(&download_url)?; | ||
| PathBuf::from(format!("preprod_artifact_{build_id}.{ext}")) | ||
| } | ||
| }; | ||
|
|
||
| info!("Downloading build {build_id} to {}", output_path.display()); | ||
|
|
||
| let tmp = TempFile::create()?; | ||
| let mut file = tmp.open()?; | ||
| let response = authenticated_api.download_installable_build(&download_url, &mut file)?; | ||
|
|
||
| if response.failed() { | ||
| bail!( | ||
| "Failed to download build (server returned status {}).", | ||
| response.status() | ||
| ); | ||
| } | ||
|
|
||
| drop(file); | ||
| fs::copy(tmp.path(), &output_path)?; | ||
|
|
||
| println!("Successfully downloaded build to {}", output_path.display()); | ||
|
|
||
| Ok(()) | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.