-
-
Notifications
You must be signed in to change notification settings - Fork 240
feat(code-mappings): Add git inference for repo and default branch #3208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
romtsn
wants to merge
8
commits into
master
Choose a base branch
from
rz/feat/code-mappings-git-inference
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+109
−12
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
9f73bc0
feat(cli): Add `code-mappings upload` command scaffold with file parsing
romtsn dfeb139
fix(code-mappings): Address PR feedback on help text and unwrap usage
romtsn 27a3b3a
feat(cli): Add git inference for repo and branch in code-mappings upload
romtsn b6e9157
style: Fix formatting in code-mappings upload
romtsn 12d1a2b
fix(code-mappings): Allow branch fallback without git remotes
romtsn 6dae115
fix(code-mappings): Preserve case when inferring repo name from remote
romtsn 62b9fbf
ref(code-mappings): Flatten git inference into helper functions
romtsn 44ef01d
style(code-mappings): Remove redundant closure to fix clippy warning
romtsn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicate output when values are inferred from git
Low Severity
When repo or branch is inferred from git,
infer_repo_nameprints"Inferred repository: ..."andinfer_default_branchprints"Inferred default branch: ...", and thenexecuteunconditionally prints"Repository: ..."and"Default branch: ..."with the same values. This produces confusing redundant output to the user showing the same information twice.Additional Locations (2)
src/commands/code_mappings/upload.rs#L145-L146src/commands/code_mappings/upload.rs#L83-L86