Homogenize bin scripts#35
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 68470b7. Configure here.
cmanallen
left a comment
There was a problem hiding this comment.
I think this is too complicated. Ideally we have one server and one client script. I would drop the "direct" clients. Proxying through the RPC covers the direct case and also gives us additional coverage by flowing through our RPC server substrate.
I think three files should be sufficient:
./rpc-server./rpc-client./sentry-client
For disambiguating providers a flag like --provider could be used in lieu of a different file:
./rpc-client get-pull-request <id> --provider=githubTacking it onto the end makes it easier to test multiple providers by changing provider names on the tail. But if that complicates command definitions then putting it elsewhere is fine too. ./rpc-client github get-pull-request <id>.
|
Agreed. I dropped the direct clients in 5113784. I merged the GitHub and GitLab clients in 1694d2a. I used a required option |
|
@jacquev6 |
|
@jacquev6 But this is lower priority than the issues Billy shared with you on Slack. |

Everything is described in the README.md.
The number of client scripts (6) is the product of:
This is reasonable for now, and arguably easier to use than a single client with several command-line options, but this should be reconsidered if either factor increases.