Update compare_commits to return "ahead_by" value#28
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 7168e6c. Configure here.
| type="gitlab", | ||
| raw={"data": raw, "headers": None}, | ||
| meta=PaginatedResponseMeta(next_cursor=None), | ||
| ) |
There was a problem hiding this comment.
GitLab ahead_by derived from truncated commits list
Low Severity
In GitLab.compare_commits, ahead_by is calculated from the length of the commits list returned by the GitLab API. Since the API can truncate this list, ahead_by may undercount the actual commits ahead. This diverges from the GitHub provider, which reports the true total.
Reviewed by Cursor Bugbot for commit 7168e6c. Configure here.
There was a problem hiding this comment.
Would it be better to make this unsupported/None for GL since it's calculated (and not correct)
| type="gitlab", | ||
| raw={"data": raw, "headers": None}, | ||
| meta=PaginatedResponseMeta(next_cursor=None), | ||
| ) |
There was a problem hiding this comment.
Would it be better to make this unsupported/None for GL since it's calculated (and not correct)
2 participants
No description provided.