Skip to content

fix(error-reporting): silence ResolutionError to prevent crash reports #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sentry wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(error-reporting): silence ResolutionError to prevent crash reports #1115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/lib/error-reporting.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ import {
* Reasons an error may be silenced (not sent to Sentry as an issue).
* Exposed as the `reason` attribute on the `cli.error.silenced` metric.
*/
type SilenceReason = "output_error" | "auth_expected" | "api_user_error";
type SilenceReason = "output_error" | "auth_expected" | "api_user_error" | "user_input_error";

/**
* Classify whether an error should be silenced.
Expand All @@ -54,6 +54,9 @@ export function classifySilenced(error: unknown): SilenceReason | null {
if (error instanceof OutputError) {
return "output_error";
}
if (error instanceof ResolutionError) {
return "user_input_error";
}
if (
error instanceof AuthError &&
(error.reason === "not_authenticated" || error.reason === "expired")
Expand Down
Loading