refactor(11/12): update manifests, config, docs, and example projects#329
Merged
cameroncooke merged 3 commits intomainfrom Apr 10, 2026
Merged
refactor(11/12): update manifests, config, docs, and example projects#329cameroncooke merged 3 commits intomainfrom
cameroncooke merged 3 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 55a323e. Configure here.
b91063e to
e6d00fe
Compare
55a323e to
22247c9
Compare
22247c9 to
785bdd9
Compare
1b4cd5c to
5da2a0b
Compare
f5391c3 to
b6e35ad
Compare
651f77a to
18de083
Compare
This was referenced Apr 9, 2026
Collaborator
Author
This was referenced Apr 9, 2026
b6e35ad to
0497670
Compare
18de083 to
8096037
Compare
0497670 to
dc62323
Compare
a3c5515 to
f79a1f8
Compare
dc62323 to
3cf09d1
Compare
f79a1f8 to
7ba6db8
Compare
1bc80ad to
8dfeb16
Compare
7ba6db8 to
34ec659
Compare
8dfeb16 to
d9a8caa
Compare
34ec659 to
b3c094d
Compare
d9a8caa to
6ea4df8
Compare
13b58c1 to
b1364d7
Compare
6ea4df8 to
86b945d
Compare
b1364d7 to
b0455f7
Compare
86b945d to
546ad1c
Compare
546ad1c to
81d1e82
Compare
2f31ed2 to
62a5be6
Compare
Comment on lines
+418
to
+428
| const waitForStop = this.waitForEvent('stopped', timeoutMs); | ||
|
|
||
| await this.request<{ threadId: number }, Record<string, never>>( | ||
| 'pause', | ||
| { threadId: thread.id }, | ||
| { timeoutMs }, | ||
| ); | ||
|
|
||
| await waitForStop; | ||
| this.executionState = { status: 'stopped', threadId: thread.id }; | ||
| } |
There was a problem hiding this comment.
Bug: If the request('pause') call fails in pauseExecution, the abandoned waitForEvent promise can cause an unhandled rejection, crashing the process.
Severity: HIGH
Suggested Fix
Wrap the request and waitForEvent calls in a try...finally block. In the finally block, ensure the waitForEvent promise is either awaited with a catch or otherwise handled to prevent an unhandled rejection if the request call fails.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: src/utils/debugger/backends/dap-backend.ts#L416-L428
Potential issue: In the `pauseExecution` function, a call is made to
`this.request('pause', ...)`. If this request fails and throws an error, the `catch`
block will handle it, but the promise returned by `waitForEvent('stopped', ...)` is left
pending. This `waitForEvent` call has an internal timeout. When this timeout is
eventually reached, it will reject the promise. Since nothing is awaiting or handling
this rejection, it becomes an unhandled promise rejection, which can terminate the
Node.js process.
aa949ff to
3c0a6bb
Compare
62a5be6 to
a089cf9
Compare
Collaborator
Author
Merge activity
|
Internal research notes that shouldn't be committed to the repository.
Changed from io.sentry.calculatorapp (which collides with the iOS Calculator example) to io.sentry.MCPTest.macOS.
3c0a6bb to
ab9afb8
Compare
cameroncooke
added a commit
that referenced
this pull request
Apr 10, 2026
…#329) This is **PR 11 of 12** in a stacked PR series that decouples the rendering pipeline from MCP transport. Depends on PR 10 (boundary rewiring). Updates all configuration files, YAML manifests, documentation, and example projects to reflect the rendering pipeline refactor. No behavioral code changes -- this is metadata, documentation, and project configuration. All tool manifests updated to reflect the simplified handler contract. Changes are consistent across all manifests: - Removed output format configuration that is now handled by the render session - Updated parameter descriptions where they referenced the old rendering model Added `manifests/resources/` directory with resource manifest definitions that were previously inline. - `package.json` + `package-lock.json`: Dependency updates and script changes - `knip.json`: Dead code analysis configuration for the new module structure - `vitest.config.ts`: Minor updates for new test paths - `vitest.flowdeck.config.ts` + `vitest.snapshot.config.ts`: New vitest configs for flowdeck integration tests and snapshot tests respectively New developer documentation explaining the rendering pipeline architecture: - `RENDERING_PIPELINE.md`: Architecture overview for contributors - `RENDERING_PIPELINE_REFACTOR.md`: Migration guide and decision log - `QUERY_TOOL_FORMAT_SPEC.md`: Specification for query tool output formatting - `FIXTURE_DESIGNS.md`: Snapshot test fixture design documentation - `STRUCTURED_XCODEBUILD_EVENTS_PLAN.md`: Design document for the xcodebuild event model - Updated `ARCHITECTURE.md`, `TESTING.md`, `MANIFEST_FORMAT.md`, `TOOL_DISCOVERY_LOGIC.md` Minor updates to example projects to work with the updated tool interfaces. Updated test files and project configuration. - `AGENTS.md`: Updated project rules - New test infrastructure: `test-helpers.ts`, `vitest-executor-safety.setup.ts` - Build scripts updated: removed `copy-build-assets.js` (no longer needed), added benchmark and capture wrapper scripts - PR 1-10/12: All code changes - **PR 11/12** (this PR): Manifests, config, docs, examples - PR 12/12: Snapshot test fixtures and benchmarks - [ ] `npx vitest run` passes - [ ] Manifest validation passes for all YAML files - [ ] Documentation renders correctly in GitHub - [ ] Example projects build successfully
cameroncooke
added a commit
that referenced
this pull request
Apr 10, 2026
…#329) This is **PR 11 of 12** in a stacked PR series that decouples the rendering pipeline from MCP transport. Depends on PR 10 (boundary rewiring). Updates all configuration files, YAML manifests, documentation, and example projects to reflect the rendering pipeline refactor. No behavioral code changes -- this is metadata, documentation, and project configuration. All tool manifests updated to reflect the simplified handler contract. Changes are consistent across all manifests: - Removed output format configuration that is now handled by the render session - Updated parameter descriptions where they referenced the old rendering model Added `manifests/resources/` directory with resource manifest definitions that were previously inline. - `package.json` + `package-lock.json`: Dependency updates and script changes - `knip.json`: Dead code analysis configuration for the new module structure - `vitest.config.ts`: Minor updates for new test paths - `vitest.snapshot.config.ts`: New vitest config for snapshot tests New developer documentation explaining the rendering pipeline architecture: - `RENDERING_PIPELINE.md`: Architecture overview for contributors - `RENDERING_PIPELINE_REFACTOR.md`: Migration guide and decision log - `QUERY_TOOL_FORMAT_SPEC.md`: Specification for query tool output formatting - `FIXTURE_DESIGNS.md`: Snapshot test fixture design documentation - `STRUCTURED_XCODEBUILD_EVENTS_PLAN.md`: Design document for the xcodebuild event model - Updated `ARCHITECTURE.md`, `TESTING.md`, `MANIFEST_FORMAT.md`, `TOOL_DISCOVERY_LOGIC.md` Minor updates to example projects to work with the updated tool interfaces. Updated test files and project configuration. - `AGENTS.md`: Updated project rules - New test infrastructure: `test-helpers.ts`, `vitest-executor-safety.setup.ts` - Build scripts updated: removed `copy-build-assets.js` (no longer needed), added benchmark and capture wrapper scripts - PR 1-10/12: All code changes - **PR 11/12** (this PR): Manifests, config, docs, examples - PR 12/12: Snapshot test fixtures and benchmarks - [ ] `npx vitest run` passes - [ ] Manifest validation passes for all YAML files - [ ] Documentation renders correctly in GitHub - [ ] Example projects build successfully
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
This is PR 11 of 12 in a stacked PR series that decouples the rendering pipeline from MCP transport. Depends on PR 10 (boundary rewiring).
Updates all configuration files, YAML manifests, documentation, and example projects to reflect the rendering pipeline refactor. No behavioral code changes -- this is metadata, documentation, and project configuration.
Manifest YAML updates (28 files)
All tool manifests updated to reflect the simplified handler contract. Changes are consistent across all manifests:
New resource manifests
Added
manifests/resources/directory with resource manifest definitions that were previously inline.Configuration
package.json+package-lock.json: Dependency updates and script changesknip.json: Dead code analysis configuration for the new module structurevitest.config.ts: Minor updates for new test pathsvitest.flowdeck.config.ts+vitest.snapshot.config.ts: New vitest configs for flowdeck integration tests and snapshot tests respectivelyDocumentation
New developer documentation explaining the rendering pipeline architecture:
RENDERING_PIPELINE.md: Architecture overview for contributorsRENDERING_PIPELINE_REFACTOR.md: Migration guide and decision logQUERY_TOOL_FORMAT_SPEC.md: Specification for query tool output formattingFIXTURE_DESIGNS.md: Snapshot test fixture design documentationSTRUCTURED_XCODEBUILD_EVENTS_PLAN.md: Design document for the xcodebuild event modelARCHITECTURE.md,TESTING.md,MANIFEST_FORMAT.md,TOOL_DISCOVERY_LOGIC.mdExample projects
Minor updates to example projects to work with the updated tool interfaces. Updated test files and project configuration.
Other
AGENTS.md: Updated project rulestest-helpers.ts,vitest-executor-safety.setup.tscopy-build-assets.js(no longer needed), added benchmark and capture wrapper scriptsStack navigation
Test plan
npx vitest runpasses