Fix shell injection vulnerability in release workflow (ENG-6554)#229
Merged
cameroncooke merged 4 commits intomainfrom Feb 21, 2026
Merged
Fix shell injection vulnerability in release workflow (ENG-6554)#229cameroncooke merged 4 commits intomainfrom
cameroncooke merged 4 commits intomainfrom
Conversation
Resolves command injection vulnerability by using environment variables instead of direct GitHub context interpolation in shell scripts. This prevents potential malicious code injection through user-controlled input in github.event_name and github.event.inputs.version. Changes: - Added env section with GH_EVENT_NAME and GH_INPUT_VERSION - Updated shell script to reference environment variables - Added proper quoting around variables Fixes: https://linear.app/getsentry/issue/ENG-6554 Parent: https://linear.app/getsentry/issue/VULN-1163 Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
commit: |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a high-severity shell injection vulnerability in the GitHub Actions release workflow.
Problem
The workflow was using direct interpolation of GitHub context data (
${{ github.event_name }}and${{ github.event.inputs.version }}) in shell scripts, which could allow an attacker to inject malicious code through user-controlled input.Solution
env:section to set environment variablesGH_EVENT_NAMEandGH_INPUT_VERSIONTesting
The workflow file syntax is valid and follows GitHub Actions best practices for security hardening.
References