android-cpp: Restore Sync control#66
Open
Kristopher Johnson (kristopherjohnson) wants to merge 3 commits intomainfrom
Open
android-cpp: Restore Sync control#66Kristopher Johnson (kristopherjohnson) wants to merge 3 commits intomainfrom
Kristopher Johnson (kristopherjohnson) wants to merge 3 commits intomainfrom
Conversation
Kristopher Johnson (kristopherjohnson)
marked this pull request as ready for review
Kristopher Johnson (kristopherjohnson)
requested a review
from Teodor Ciuraru (teodorciuraru)
as a code owner
Collaborator
Author
|
Note: the failed |
Teodor Ciuraru (teodorciuraru)
approved these changes
Jul 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore Sync control which was removed due to a sync bug in the 4.9 C++ SDK.
The Kotlin code related to the Sync control UI is substantially the same as the code in the Kotlin Quickstart app. However, there was a bug in the 4.9 C++ SDK which caused the C++ code to crash in
ditto_sdk_transports_ble_destroy()whenstop_sync()was called, so I removed the Sync control from the app. In the 4.10 SDK, the bug in the core transports code has been fixed, so the crash is no longer repeatable.Closes SDKS-556