feat: add tests for mellea optional dependencies#724
Merged
jakelorocco merged 2 commits intomainfrom Mar 26, 2026
Merged
Conversation
Merge ProtectionsYour pull request matches the following merge protections and will not be merged until they are valid. 🟢 Enforce conventional commitWonderful, this rule succeeded.Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
|
Contributor
|
The PR description has been updated. Please fill out the template for your PR to be reviewed. |
8 tasks
jakelorocco
force-pushed
the
jal/package-test-3
branch
3 times, most recently
from
7936cf0 to
65ab6a7
Compare
Contributor
Author
|
Tests are marked with slow; ran locally and on blue vela and passed in both envs. |
ajbozarth
reviewed
Mar 23, 2026
jakelorocco
force-pushed
the
jal/package-test-3
branch
from
65ab6a7 to
445acf0
Compare
psschwei
approved these changes
Mar 26, 2026
Member
psschwei
left a comment
psschwei
left a comment
There was a problem hiding this comment.
LGTM with one minor suggestion (non-blocking)
Might be good for @ajbozarth or @planetf1 to take a look too before merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Misc PR
Type of PR
Description
Adds tests that check for mellea imports given an optional dependency group (looks for expected imports to work and for unexpected imports to fail). Also checks that all optional dependency groups are covered in the test set.
Testing