Null-check physics list before dereferencing it#145
Merged
Conversation
GetReferencePhysList() returns nullptr for an unrecognized list name, but RegisterPhysics() was called before the null check, segfaulting on a typo instead of emitting ERR_PHYSLISTERROR. Move the check ahead of the dereference; log->error is [[noreturn]], so the null path terminates cleanly before RegisterPhysics. Fixes gemc#130 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
g4alt::G4PhysListFactory::GetReferencePhysList()returnsnullptrfor an unrecognized list name, butRegisterPhysics()was called before theif (!physList)guard — a typo'd physics-list name segfaulted instead of emittingERR_PHYSLISTERROR. The null check now runs before the dereference.log->erroris[[noreturn]], so the null path terminates cleanly beforeRegisterPhysics(also avoiding the leakedG4StepLimiterPhysics).Validation: translation unit recompiled cleanly with Geant4 11.4.1 / ROOT 6.38 / Qt 6.9 (ghcr.io/gemc/src:dev-almalinux-10).
Fixes #130