Skip to content

Harden declaration parsing#305

Merged
fingolfin merged 1 commit intomasterfrom
codex/parser-cleanup-master-base
Feb 26, 2026
Merged

Harden declaration parsing#305
fingolfin merged 1 commit intomasterfrom
codex/parser-cleanup-master-base

Conversation

@fingolfin
Copy link
Member

@fingolfin fingolfin commented Feb 26, 2026

Normalize InstallMethod names by stripping quotes, matching Declare... parsing.

Add explicit EOF guards for declaration header/filter scanning loops to produce clear parser errors instead of implicit failures.

Co-authored-by: Codex codex@openai.com

Normalize InstallMethod names by stripping quotes, matching
Declare... parsing.

Add explicit EOF guards for declaration header/filter scanning loops
to produce clear parser errors instead of implicit failures.

Co-authored-by: Codex <codex@openai.com>
@fingolfin fingolfin force-pushed the codex/parser-cleanup-master-base branch from e2b28a2 to 617fb16 Compare February 26, 2026 22:36
@fingolfin fingolfin changed the title codex/parser cleanup master base Harden declaration parsing Feb 26, 2026
@fingolfin fingolfin merged commit a609b04 into master Feb 26, 2026
7 checks passed
@fingolfin fingolfin deleted the codex/parser-cleanup-master-base branch February 26, 2026 22:38
@codecov
Copy link

codecov bot commented Feb 27, 2026

Codecov Report

❌ Patch coverage is 6.25000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.41%. Comparing base (a3cc237) to head (617fb16).
⚠️ Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
gap/Parser.gi 6.25% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #305      +/-   ##
==========================================
- Coverage   84.97%   84.41%   -0.57%     
==========================================
  Files          13       13              
  Lines        2217     2233      +16     
==========================================
+ Hits         1884     1885       +1     
- Misses        333      348      +15     
Files with missing lines Coverage Δ
gap/Parser.gi 80.77% <6.25%> (-1.70%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant