fix: preserve full input context in span attributes for multi-message…#152
Open
rite7sh wants to merge 2 commits intofuture-agi:mainfrom
Open
fix: preserve full input context in span attributes for multi-message…#152rite7sh wants to merge 2 commits intofuture-agi:mainfrom
rite7sh wants to merge 2 commits intofuture-agi:mainfrom
Conversation
JayaSurya-27
requested changes
Apr 9, 2026
| OUTPUT_MIME_TYPE = "output.mime_type" | ||
| INPUT_VALUE = "input.value" | ||
| INPUT_MIME_TYPE = "input.mime_type" | ||
| INPUT_RAW = "input.raw" |
Collaborator
There was a problem hiding this comment.
Don't introduce INPUT_RAW — adding new span attributes has downstream implications. The fix should not require a new attribute.
Author
There was a problem hiding this comment.
yea, you are right the downstream impli would help.. lemme fix it.
Comment on lines
59
to
-63
| if eval_input: | ||
| eval_input_str = " \n ".join(map(str, eval_input)) | ||
| span.set_attribute(SpanAttributes.INPUT_VALUE, eval_input_str) | ||
| if eval_input and len(eval_input) > 0: | ||
| span.set_attribute(SpanAttributes.INPUT_VALUE, eval_input[0]) |
Collaborator
There was a problem hiding this comment.
Just Deleting these lines should solve the issue of data being overwritten , no need to introduce any new span attributes
Author
|
@JayaSurya-27 let me know if the 2d31b8f works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #151
Summary
Fixes an issue where
SpanAttributes.INPUT_VALUEwas overwritten multiple times in_process_input_data, with the final assignment reducing it to only the first message.Changes
INPUT_VALUEonly once using full joined inputeval_input[0]Impact
Preserves full input context for multi-message traces, improving trace correctness and observability.
Testing
PYTHONPATH=frameworks/openai poetry run pytest tests/test_framework_openai.py -v