FSharp.Data.Html suggested change to enable people to use the html parser without hiding representation without having to hack the code itself.#1499
Merged
dsyme merged 4 commits intofsprojects:mainfrom Feb 21, 2026
Conversation
…ng representation without having to hack the code itself.
dsyme
approved these changes
Mar 21, 2025
Contributor
🏥 CI Failure Analysis - Run #249Issue: Both CI jobs (Ubuntu & Windows) failed on the Root Cause: The file Solution: Run the formatter command to fix the formatting: dotnet run --project build/build.fsproj -- -t FormatThen commit the formatted changes to fix the CI build. Error Details:
|
Contributor
|
🤖 Workflow run triggered by this comment |
Fixed formatting in build/build.fs to comply with Fantomas standards. This resolves the CI CheckFormat failure. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
✅ CI Fix AppliedI've successfully fixed the CI formatting failure by running the Fantomas formatter on Changes Made:
Root Cause:The CI was failing on the Solution:Ran The CI should now pass the CheckFormat step. ✅
|
6 tasks
dsyme
pushed a commit
that referenced
this pull request
Feb 21, 2026
Consolidate all changes since 6.5.0 into RELEASE_NOTES.md and mark 6.6.0 as released, opening 6.7.0 unreleased section. Changes included in 6.6.0: - Security fix: XXE vulnerability in XML parsing (#1596) - Bug fix: XML provider uses XDocument reader instead of ReadToEnd (#1527) - Performance: HTML parser CharList uses StringBuilder (~43% faster) (#1550) - Performance: JSON string serialization bulk writes (#1562) - Performance: RemoveAdorners fast-path for adorner-free strings (#1540) - Feature: HTML HIDE_REPRESENTATION compile-time opt-in (#1499) - Documentation: Fix links (#1597) - Tests: Expanded coverage across all modules Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm looking to use the html parsing DSL without the encumbering that active pattern brings in terms of using those to "avoid breaking changes" in the DU definitions, costing in terms of tooling and ways to do the matching using it.
For now, this is just so people can make their own build by flipping a tag in the fsproj, but we may consider having something similar to https://github.com/fsprojects/FSharp.Data.SqlClient/blob/c6e48a47eb1d64c7de7596bae3cb50a548592357/src/SqlClient/DataTable.fs#L10 as default, and provide the same package with "HIddenRepresentation" suffix to the nuget package name, for those that feel their code will be more resilient to this library changing things.
related: #1227, #1102, fsharp/fslang-suggestions#1341