Refactored zoom threshold logic and improve compact label rendering in nodes#591
Open
stijnpotters1 wants to merge 1 commit into
Open
Refactored zoom threshold logic and improve compact label rendering in nodes#591stijnpotters1 wants to merge 1 commit into
stijnpotters1 wants to merge 1 commit into
Conversation
stijnpotters1
commented
Jun 30, 2026
stijnpotters1
commented
Contributor
Contributor
Author
|
@philipsens What do you think of this? Now the labels auto scale with zooming |
|
Matthbo
approved these changes
Jul 2, 2026
Member
|
I'll check it out and test it :) |
philipsens
requested changes
Jul 2, 2026
philipsens
left a comment
philipsens
left a comment
Member
There was a problem hiding this comment.
The stationary text feels nice and readable. But it could be less bold (medium instead of semibold). Also, I think the forwards should also scale with the zooming, so it is possible to see what is happening here:
| {value || key} | ||
| </span> | ||
| ))} | ||
| <span className="text-center leading-snug font-semibold whitespace-nowrap" style={{ fontSize: labelFontSize }}> |
Member
There was a problem hiding this comment.
Suggested change
| <span className="text-center leading-snug font-semibold whitespace-nowrap" style={{ fontSize: labelFontSize }}> | |
| <span className="text-center leading-snug font-medium whitespace-nowrap" style={{ fontSize: labelFontSize }}> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.