Skip to content

Added dynamic width to properly nest elements in objects. Fixed bug with icons not working on dark theme#406

Merged
VincentvanMedenbach merged 7 commits intomasterfrom
datamapper-dynamic-width
Mar 31, 2026
Merged

Added dynamic width to properly nest elements in objects. Fixed bug with icons not working on dark theme#406
VincentvanMedenbach merged 7 commits intomasterfrom
datamapper-dynamic-width

Conversation

@VincentvanMedenbach
Copy link
Copy Markdown
Contributor

image

@Matthbo
Copy link
Copy Markdown
Member

Matthbo commented Mar 30, 2026

Why is the extra source not like the first source?
The idea is that no matter how many sources you add, the interface is uniform. But now I see a blue background and "Extra source:" which is kind of obvious already because its in its own container and ready to be mapped from

@VincentvanMedenbach
Copy link
Copy Markdown
Contributor Author

Why is the extra source not like the first source? The idea is that no matter how many sources you add, the interface is uniform. But now I see a blue background and "Extra source:" which is kind of obvious already because its in its own container and ready to be mapped from

Honestly, i completely forgot about the styling of the extra sources and the blue you see now is what it was when i first made it. Just discussed the design with sergi and he's made a design to visualize the extra sources better. Will update this pr whenever i've implemented it!

@VincentvanMedenbach VincentvanMedenbach removed the request for review from Matthbo March 31, 2026 08:22
@sonarqubecloud
Copy link
Copy Markdown

Copy link
Copy Markdown
Member

@Matthbo Matthbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment about HoverInfo, but if there isnt a reusable one then no worries

@VincentvanMedenbach VincentvanMedenbach merged commit ada84b9 into master Mar 31, 2026
5 checks passed
@VincentvanMedenbach VincentvanMedenbach deleted the datamapper-dynamic-width branch March 31, 2026 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants