fix: replacements splitted between chunks W-20635868#1699
Open
Bartheleway wants to merge 1 commit intoforcedotcom:mainfrom
Open
fix: replacements splitted between chunks W-20635868#1699Bartheleway wants to merge 1 commit intoforcedotcom:mainfrom
Bartheleway wants to merge 1 commit intoforcedotcom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When using replacement strings on big files, it happen a replacement string is split in two different chunks thus not being replaced.
The modification consider treating only complete lines as replacement string should not be split on several lines. Remaining characters are added to the next chunk in order to be processed as well.
What issues does this PR fix or reference?
forcedotcom/cli#3461, @W-20635868@
Functionality Before
Replacement process miss some tokens.
Functionality After
All tokens are correctly replaced.
Tested locally on the file I had issue with and it solved it without causing other impact.