Skip to content

Update more dash_site commands to support multiple sites#13388

Merged
parlough merged 2 commits into
mainfrom
misc/build-multiple-sites
May 16, 2026
Merged

Update more dash_site commands to support multiple sites#13388
parlough merged 2 commits into
mainfrom
misc/build-multiple-sites

Conversation

@parlough
Copy link
Copy Markdown
Member

Contributes to #13148

@parlough parlough requested review from a team and sfshaza2 as code owners May 16, 2026 02:53
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the site build and management tools to support site-specific configurations by expanding the Site enum with metadata for hostnames, path segments, and feature support. Commands such as build, clean, and refresh-excerpts were updated to utilize these new properties. Feedback was provided to ensure the build process in build.dart terminates immediately upon a non-zero exit code from the jaspr build command to avoid operations on incomplete artifacts.

Comment thread tool/dash_site/lib/src/commands/build.dart Outdated
Copy link
Copy Markdown
Contributor

@sfshaza2 sfshaza2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@flutter-website-bot
Copy link
Copy Markdown
Collaborator

flutter-website-bot commented May 16, 2026

Visit the preview URL for this PR (updated for commit b50ecca):

https://flutter-docs-prod--pr13388-misc-build-multiple-sites-vu2xct9a.web.app

@parlough parlough merged commit 479384a into main May 16, 2026
10 checks passed
@parlough parlough deleted the misc/build-multiple-sites branch May 16, 2026 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants