Enable running site-specific tests#13387
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the test-dart command to support testing site directories using the dart executable while continuing to use flutter for example projects. It introduces a tuple-based structure to track directories and their corresponding test executables and adds logic to verify the existence of test directories before execution. I have no feedback to provide.
sfshaza2
reviewed
May 16, 2026
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
lgtm, once the build is happy
sfshaza2
approved these changes
May 16, 2026
Contributor
sfshaza2
left a comment
sfshaza2
left a comment
There was a problem hiding this comment.
oops, forgot to check approve...
Collaborator
|
Visit the preview URL for this PR (updated for commit 2013e6e): https://flutter-docs-prod--pr13387-misc-test-sites-l6sp6sqt.web.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #13148