[camera_android_camerax] Setup agent skills camerax by reidbaker · Pull Request #11930 · flutter/packages

reidbaker · 2026-06-17T22:09:06Z

Setup the new agent skills architecture for camera_android_camerax:
Taking over from #11895

Remotely managed Skills: Third-party are in a top level directory pr remote repo so that licenses can be included. Then they are symlinked into packages that want them.
Published Skills: Added a new empty directory for skills that are for users of camera_android_camerax.
Contributor Skills: Added a new directory for contributor skills and authored an internal `check-readiness` skill configured to enforce repository hygiene.
Linter & Safety: Pinned `dart_skills_lint` to the newly supported `individual_skills` hash. Added `tracked_skills_publishing_test.dart` to enforce that internal tracked skills cannot be accidentally published.

Tooling changes:

Ignore dart pub --dry-run errors (in publish_check) if the folders are in .pubignore

Future changes:

migrate bash script to dart
make analyze run on .agents/skills/* directories
update the tooling to not need changelog and versioning if you modify .agents/skills

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩²

- Add dart_skills_lint dependency and configuration - Create .agents/skills and skills directories with documentation - Set up isolated third_party skills installation for remote skills - Symlink remote skills into .agents/skills - Add validate_skills_test.dart for CI integration

reidbaker · 2026-06-17T22:09:34Z

No changelog needed because none of the changes are user facing only contributor facing.

gemini-code-assist

Code Review

This pull request adds local and third-party AI agent skills to the camera_android_camerax package, including configuration files, tests, and documentation for managing them. Feedback on these changes identifies a missing verification script (check.sh) referenced in the readiness skill, an invalid license file containing a 404 error for the anthropics-skills dependency, a violation of Dart API boundaries due to importing internal src/ files in a test, and fragile path parsing in tracked_skills_publishing_test.dart that could fail in monorepo CI environments.

camsim99

Left some high level questions!

…ments

…sInternalRule

reidbaker · 2026-06-18T23:08:14Z

@camsim99 I have some work happening to turn this into dart code but if you are ok with it I would like to land that change independently.

gemini-code-assist

Code Review

This pull request introduces local and third-party AI agent skills to the camera_android_camerax package, including a readiness check script, custom lint rules, and validation tests. Feedback on the changes suggests improving robustness by replacing an unsafe cast with a safe type check, wrapping a process execution in a try-catch block to handle potential exceptions, and verifying the presence of git and a git repository in the shell script before running git status.

reidbaker · 2026-06-19T17:42:40Z

/gemini-code-review

reidbaker · 2026-06-19T19:21:20Z

      return true;
    }

-    if (!getBoolArg(_allowPrereleaseFlag)) {


this code was not deleted only moved.

camsim99

LGTM just had some questions about EnforceTrackedSkillsInternalRule for my own understanding! Sorry for the delayed review!

camsim99 · 2026-06-22T15:27:20Z

Why does this live within the camera_android_camerax plugin? Assuming this might be something we would want available to all plugins but we are just starting with it here?

Also why is it in the test/ directory? Is that standard for custom skill lints?

Why does this live within the camera_android_camerax plugin? Assuming this might be something we would want available to all plugins but we are just starting with it here?

There is already a lint that ensures that skills that have the lint enabled are not published. This is more of a meta test that makes sure that for this package (later repo) that we have configured the skills correctly.

Also why is it in the test/ directory? Is that standard for custom skill lints?
I am still working on the standard for where custom lints should live more broadly in dart packages. For this repo the lint will likely move to the repo tooling directory the first time we have another package adopt skills and want to enforce this configuration. You can think of custom lints kind of like test utils classes.

stuartmorgan-g · 2026-06-22T16:10:24Z

@@ -0,0 +1,26 @@
+Copyright 2026 The Flutter Authors. All rights reserved.


Why is Flutter code in a third_party directory?

stuartmorgan-g · 2026-06-22T16:13:55Z

@@ -0,0 +1,23 @@
+# Third-Party Agent Skills


Can we make a third_party/skills/ that contains this and all the skills, instead of making the individual skills peers of third_party/packages/, and having the README for all of third-party sound like it's about skills?

reidbaker · 2026-06-22T16:36:00Z

I talked to @stuartmorgan-g out of band and we have a better way of determining what skills should be configured with dont publish check. I am going to resolve the paths for all the skills and filter out third_party. Holding landing this pr for that change.

reidbaker added 7 commits June 17, 2026 16:49

feat: Add check-readiness skill

26b37ae

feat: Add local check-readiness skill and configure linter

d825767

test: ensure tracked skills cannot be published accidentally

f7f0646

build: pin dart_skills_lint to support individual_skills

ea27e43

test: rewrite tracked skills test to use ValidationSession API

9ac31a2

test: fix analyzer warnings

87cfaf1

reidbaker added the override: no changelog needed Override the check requiring CHANGELOG updates for most changes label Jun 17, 2026

flutter-dashboard Bot added the CICD Run CI/CD label Jun 17, 2026

github-actions Bot added the p: camera label Jun 17, 2026

reidbaker marked this pull request as draft June 17, 2026 22:09

gemini-code-assist Bot reviewed Jun 17, 2026

View reviewed changes

camsim99 self-requested a review June 17, 2026 22:53

build: update dart_skills_lint to 8f85e82b on main

acbcc3e

github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026

camsim99 reviewed Jun 18, 2026

View reviewed changes

Comment thread third_party/anthropics-skills/LICENSE Outdated

Comment thread third_party/README.md Outdated

Comment thread packages/camera/camera_android_camerax/.agents/skills/check-readiness/SKILL.md

test: rewrite tracked skills test to use yaml parsing, address PR com…

7eabf5f

…ments

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

test: revert yaml parsing, use public ValidationSession from repo

9e0d9e5

github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026

test: revert to ValidationSession and use ignore implementation_imports

6b68664

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

test: replace yaml parsing with custom skill rule EnforceTrackedSkill…

0942453

…sInternalRule

github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026

test: extract EnforceTrackedSkillsInternalRule to its own file with docs

9471107

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

reidbaker commented Jun 18, 2026

View reviewed changes

reidbaker marked this pull request as ready for review June 18, 2026 23:50

ci: allow dart_skills_lint in packages

c4e832f

github-actions Bot removed the CICD Run CI/CD label Jun 18, 2026

gemini-code-assist Bot reviewed Jun 18, 2026

View reviewed changes

flutter-dashboard Bot added the CICD Run CI/CD label Jun 18, 2026

test: fix internal rule validation feedback

acc34a5

reidbaker force-pushed the setup-agent-skills-camerax branch from a272087 to acc34a5 Compare June 19, 2026 00:00

github-actions Bot removed the CICD Run CI/CD label Jun 19, 2026

reidbaker added the CICD Run CI/CD label Jun 19, 2026

Fix missing copyright headers in check-readiness agent skill

288e5ec

github-actions Bot removed the CICD Run CI/CD label Jun 19, 2026

reidbaker added CICD Run CI/CD override: no versioning needed Override the check requiring version bumps for most changes labels Jun 19, 2026

reidbaker added 9 commits June 19, 2026 15:16

Support .pubignore in publish-check

43be3d1

Add tests for publish_check pubignore parsing

8d17949

Fix .gitignore for check-readiness skill and symlinked skills

81c1c52

Revert un-ignoring of symlinked skills

438537c

Add TODO for tracking dart-lang/pub issue 4841

f64190b

Group pubignore tracking tests under issue 4841

14d7cfc

Move TODO out of group name

d7f024e

Fix analyzer warnings

bc37ae6

Fix .gitignore un-ignore rule overreach

16e3f28

github-actions Bot removed the CICD Run CI/CD label Jun 19, 2026

reidbaker commented Jun 19, 2026

View reviewed changes

reidbaker added the CICD Run CI/CD label Jun 19, 2026

reidbaker requested a review from camsim99 June 19, 2026 19:30

camsim99 approved these changes Jun 22, 2026

View reviewed changes

reidbaker requested a review from stuartmorgan-g June 22, 2026 16:04

stuartmorgan-g reviewed Jun 22, 2026

View reviewed changes

		@@ -0,0 +1,26 @@
		Copyright 2026 The Flutter Authors. All rights reserved.

Conversation

reidbaker commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pre-Review Checklist

Footnotes

Uh oh!

reidbaker commented Jun 17, 2026

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

reidbaker commented Jun 19, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

camsim99 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

reidbaker commented Jun 22, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

reidbaker commented Jun 17, 2026 •

edited

Loading