Skip to content

fix: keep network search field enabled after clearing calls #9855

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ishaquehassan wants to merge 4 commits into
base: master
Choose a base branch
from
+51 −7
Open

fix: keep network search field enabled after clearing calls #9855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
09e0942
fix: keep network search field enabled after clearing calls
ishaquehassan Jun 15, 2026
063ec1d
Add release note entry for network search field fix (#9855)
ishaquehassan Jun 15, 2026
912b2e1
refactor: drop redundant filteredData listener in network controls
ishaquehassan Jun 15, 2026
e1de241
fix: reload network test fixtures each test to prevent shared-ref drain
ishaquehassan Jun 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions packages/devtools_app/lib/src/screens/network/network_screen.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,6 @@ class _NetworkProfilerControlsState extends State<_NetworkProfilerControls>
_recording = controller.recordingNotifier.value;
});
});

addAutoDisposeListener(controller.filteredData);
}

@override
Expand All @@ -205,7 +203,6 @@ class _NetworkProfilerControlsState extends State<_NetworkProfilerControls>
}

final screenWidth = ScreenSize(context).width;
final hasRequests = controller.filteredData.value.isNotEmpty;
return Column(
Comment thread
ishaquehassan marked this conversation as resolved.
children: [
Row(
Expand Down Expand Up @@ -233,7 +230,6 @@ class _NetworkProfilerControlsState extends State<_NetworkProfilerControls>
Expanded(
child: SearchField<NetworkController>(
searchController: controller,
searchFieldEnabled: hasRequests,
searchFieldWidth: screenWidth <= MediaSize.xs
? defaultSearchFieldWidth
: wideSearchFieldWidth,
Expand Down
4 changes: 3 additions & 1 deletion packages/devtools_app/release_notes/NEXT_RELEASE_NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ TODO: Remove this section if there are not any updates.

## Network profiler updates

TODO: Remove this section if there are not any updates.
* Fixed the Network tab search field becoming disabled after clearing all
requests, so the search query can now be edited at any time. -
[#9855](https://github.com/flutter/devtools/pull/9855)

## Logging updates

Expand Down
50 changes: 48 additions & 2 deletions packages/devtools_app/test/screens/network/network_profiler_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ void main() {
setUpAll(() {
setGlobal(OfflineDataController, OfflineDataController());
socketProfile = loadSocketProfile();
httpProfile = loadHttpProfile();
setGlobal(IdeTheme, IdeTheme());
setGlobal(
DevToolsEnvironmentParameters,
ExternalDevToolsEnvironmentParameters(),
Expand All @@ -65,6 +63,12 @@ void main() {

group('Network Profiler', () {
setUp(() {
// Reload the fixtures for every test. Clearing requests mutates these
// shared profiles in place (FakeVmServiceWrapper clears the same lists
// aliased by _startingRequests/_startingSockets), so a test that taps
// Clear would otherwise leave them empty for the next test.
socketProfile = loadSocketProfile();
httpProfile = loadHttpProfile();
fakeServiceConnection = FakeServiceConnectionManager(
service: FakeServiceManager.createFakeService(
socketProfile: socketProfile,
Expand Down Expand Up @@ -338,6 +342,48 @@ void main() {
// Wait to ensure all the timers have been cancelled.
await tester.pumpAndSettle(const Duration(seconds: 2));
});

testWidgetsWithWindowSize(
'search field stays enabled after clearing',
windowSize,
(WidgetTester tester) async {
// Load the network profiler screen.
controller = NetworkController();
await pumpNetworkScreen(tester);

// Populate the screen with requests.
await loadRequestsAndCheck(tester);

Finder searchFieldTextField() => find.descendant(
of: find.byType(SearchField<NetworkController>),
matching: find.byType(TextField),
);

// The search field is enabled while requests are present.
expect(
tester.widget<TextField>(searchFieldTextField()).enabled,
isTrue,
);

// Pause the profiler so polling does not repopulate the requests after
// they are cleared below.
await tester.tap(find.byType(StartStopRecordingButton));
await tester.pumpAndSettle();

// Clear the results.
await tester.tap(find.byType(ClearButton));
await tester.pumpAndSettle(const Duration(seconds: 2));
expect(controller.requests.value, isEmpty);

// The search field must stay enabled even with no requests present, so
// the query can still be edited before the next batch of requests
// arrives.
expect(
tester.widget<TextField>(searchFieldTextField()).enabled,
isTrue,
);
},
);
});

group('NetworkRequestOverviewView', () {
Expand Down