-
Notifications
You must be signed in to change notification settings - Fork 382
Specify that widget rebuilds is only available in debug-mode #9733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Bingtagui404
wants to merge
1
commit into
flutter:master
Choose a base branch
from
Bingtagui404:fix/widget-rebuild-debug-mode-9730
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -92,6 +92,19 @@ class _RebuildStatsViewState extends State<RebuildStatsView> | |
|
|
||
| @override | ||
| Widget build(BuildContext context) { | ||
| final isProfileBuild = | ||
| serviceConnection.serviceManager.connectedApp?.isProfileBuildNow ?? | ||
| false; | ||
| if (isProfileBuild) { | ||
| return const Center( | ||
| child: Text( | ||
| 'Rebuild information is not available for this frame.\n' | ||
| 'Widget rebuild counts are only available when running ' | ||
| 'an app in debug-mode.', | ||
| textAlign: TextAlign.center, | ||
| ), | ||
| ); | ||
| } | ||
| return Column( | ||
| crossAxisAlignment: CrossAxisAlignment.start, | ||
| children: [ | ||
|
|
@@ -138,7 +151,7 @@ class _RebuildStatsViewState extends State<RebuildStatsView> | |
| if (metrics.isEmpty) { | ||
| return const Center( | ||
| child: Text('Interact with the app to trigger rebuilds.'), | ||
| ); // No data to display but there should be data soon. | ||
| ); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I don't think this comment needs to be removed. |
||
| } | ||
| return RebuildTable( | ||
| key: const Key('Rebuild Table'), | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add test for profile mode, thank you!