feat: add storage.total_limit_size support to splunk output#2009
Open
geirra wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds storage.total_limit_size configuration support to the Fluent Bit Splunk output plugin in Fluent Operator, exposing it as totalLimitSize and wiring it through CRD schemas, Helm CRDs, and usage docs.
Changes:
- Added
totalLimitSizeto the Splunk output API type and render it into Fluent Bit params asstorage.total_limit_size. - Updated Splunk output plugin documentation to include the new field.
- Regenerated CRDs/manifests/Helm CRD artifacts to include the new schema property.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| manifests/setup/setup.yaml | Regenerated install manifest CRDs to include totalLimitSize under Splunk output schema. |
| docs/plugins/fluentbit/output/splunk.md | Documents the new totalLimitSize field for Splunk output. |
| config/crd/bases/fluentbit.fluent.io_outputs.yaml | Regenerated Output CRD schema to include totalLimitSize for Splunk. |
| config/crd/bases/fluentbit.fluent.io_clusteroutputs.yaml | Regenerated ClusterOutput CRD schema to include totalLimitSize for Splunk. |
| charts/fluent-operator/crds/fluentbit.fluent.io_outputs.yaml | Helm-packaged Output CRD updated with totalLimitSize. |
| charts/fluent-operator/crds/fluentbit.fluent.io_clusteroutputs.yaml | Helm-packaged ClusterOutput CRD updated with totalLimitSize. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_outputs.yaml | Fluent Bit CRD chart template updated with totalLimitSize. |
| charts/fluent-operator-fluent-bit-crds/templates/fluentbit.fluent.io_clusteroutputs.yaml | Fluent Bit ClusterOutput CRD chart template updated with totalLimitSize. |
| apis/fluentbit/v1alpha2/plugins/output/splunk_types.go | Adds TotalLimitSize to Splunk output and inserts storage.total_limit_size into generated params. |
| apis/fluentbit/v1alpha2/plugins/output/splunk_types_test.go | Adds unit test validating storage.total_limit_size is emitted from TotalLimitSize. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds
storage.total_limit_sizesupport to the Splunk output plugin, enablingoperators to limit the maximum on-disk chunk buffer size per Splunk output.
Follows the exact same pattern already implemented in 7 other output plugins
(Elasticsearch, OpenTelemetry, Syslog, Loki, Kafka, OpenSearch and HTTP).
Which issue(s) this PR fixes:
None
Does this PR introduced a user-facing change?